You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/12/02 06:17:15 UTC
[GitHub] [shardingsphere] dmsolr opened a new pull request #8467: [DISUSS]Build on multi operating system
dmsolr opened a new pull request #8467:
URL: https://github.com/apache/shardingsphere/pull/8467
Changes proposed in this pull request:
- Run CI on windows, mac os, and ubuntu.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #8467: [DISUSS]Build on multi operating system
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #8467:
URL: https://github.com/apache/shardingsphere/pull/8467#issuecomment-737033567
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8467?src=pr&el=h1) Report
> Merging [#8467](https://codecov.io/gh/apache/shardingsphere/pull/8467?src=pr&el=desc) (a264dbe) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b56bfd24177ad1f75743815a0cf956eb03233dfa?el=desc) (b56bfd2) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/8467?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8467 +/- ##
============================================
- Coverage 73.26% 73.25% -0.01%
Complexity 602 602
============================================
Files 1520 1520
Lines 24056 24056
Branches 4238 4238
============================================
- Hits 17624 17622 -2
- Misses 5272 5273 +1
- Partials 1160 1161 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8467?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...osition/resume/ResumeBreakPointManagerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/8467/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcG9zaXRpb24vcmVzdW1lL1Jlc3VtZUJyZWFrUG9pbnRNYW5hZ2VyRmFjdG9yeS5qYXZh) | `75.00% <0.00%> (-12.50%)` | `0.00% <0.00%> (ø%)` | |
| [...ext/transaction/GovernanceTransactionContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/8467/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvbnRleHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29udGV4dC90cmFuc2FjdGlvbi9Hb3Zlcm5hbmNlVHJhbnNhY3Rpb25Db250ZXh0cy5qYXZh) | `93.33% <0.00%> (-6.67%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8467?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8467?src=pr&el=footer). Last update [b56bfd2...9bcce26](https://codecov.io/gh/apache/shardingsphere/pull/8467?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io edited a comment on pull request #8467: [DISUSS]Build on multi operating system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #8467:
URL: https://github.com/apache/shardingsphere/pull/8467#issuecomment-737033567
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8467?src=pr&el=h1) Report
> Merging [#8467](https://codecov.io/gh/apache/shardingsphere/pull/8467?src=pr&el=desc) (9bcce26) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b56bfd24177ad1f75743815a0cf956eb03233dfa?el=desc) (b56bfd2) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/8467?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8467 +/- ##
============================================
- Coverage 73.26% 73.25% -0.01%
Complexity 602 602
============================================
Files 1520 1520
Lines 24056 24056
Branches 4238 4238
============================================
- Hits 17624 17622 -2
- Misses 5272 5273 +1
- Partials 1160 1161 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8467?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...osition/resume/ResumeBreakPointManagerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/8467/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcG9zaXRpb24vcmVzdW1lL1Jlc3VtZUJyZWFrUG9pbnRNYW5hZ2VyRmFjdG9yeS5qYXZh) | `75.00% <0.00%> (-12.50%)` | `0.00% <0.00%> (ø%)` | |
| [...ext/transaction/GovernanceTransactionContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/8467/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvbnRleHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29udGV4dC90cmFuc2FjdGlvbi9Hb3Zlcm5hbmNlVHJhbnNhY3Rpb25Db250ZXh0cy5qYXZh) | `93.33% <0.00%> (-6.67%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8467?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8467?src=pr&el=footer). Last update [b56bfd2...9bcce26](https://codecov.io/gh/apache/shardingsphere/pull/8467?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yu199195 merged pull request #8467: [DISUSS]Build on multi operating system
Posted by GitBox <gi...@apache.org>.
yu199195 merged pull request #8467:
URL: https://github.com/apache/shardingsphere/pull/8467
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yu199195 commented on a change in pull request #8467: [DISUSS]Build on multi operating system
Posted by GitBox <gi...@apache.org>.
yu199195 commented on a change in pull request #8467:
URL: https://github.com/apache/shardingsphere/pull/8467#discussion_r534105321
##########
File path: .github/workflows/maven-on-windows.yml
##########
@@ -0,0 +1,50 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# This workflow will build a Java project with Maven
+# For more information see: https://help.github.com/actions/language-and-framework-guides/building-and-testing-java-with-maven
+
+name: Java CI with Maven
+
+on:
+ push:
+ branches: [ master ]
+ pull_request:
+ branches: [ master ]
+
+jobs:
+ build-on-windows:
+ runs-on: windows-latest
+ steps:
+ - name: Cache Maven Repos
+ uses: actions/cache@v2
+ with:
+ path: ~/.m2/repository
+ key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ ${{ runner.os }}-maven-
+ - name: Support longpaths
+ run: git config --system core.longpaths true
+ - uses: actions/checkout@v2
+ - name: Set up JDK 8
+ uses: actions/setup-java@v1
+ with:
+ java-version: 8
+ - name: Build with Maven
+ run: ./mvnw -B clean cobertura:cobertura -D"maven.javadoc.skip"=true install
+ - name: Build examples with Maven
+ run: ./mvnw -B -f examples/pom.xml clean package -DskipTests
Review comment:
keep blank line in the end
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org