You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/18 17:29:08 UTC

[GitHub] [incubator-superset] bryanck opened a new pull request #10361: check for empty dataframes before processing results

bryanck opened a new pull request #10361:
URL: https://github.com/apache/incubator-superset/pull/10361


   ### SUMMARY
   This is a small change to check for an empty dataframe before accessing it by column name for processing. This allows charts to display an empty results message instead of a cryptic error message.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before (sunburst chart example):
   ![features-2020-07-18T16-34-55 154Z](https://user-images.githubusercontent.com/5475421/87858208-11336880-c8e1-11ea-8b0c-ab08a079f83d.jpg)
   
   After:
   ![features-2020-07-18T16-38-02 507Z](https://user-images.githubusercontent.com/5475421/87858211-142e5900-c8e1-11ea-88a3-497a620c7578.jpg)
   
   
   ### TEST PLAN
   Create one of the chart types affected, e.g. Sunburst. Select a filter that returns no rows. Make sure the chart displays the empty results message instead of the error message.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro merged pull request #10361: fix: check for empty dataframes before processing results

Posted by GitBox <gi...@apache.org>.
villebro merged pull request #10361:
URL: https://github.com/apache/incubator-superset/pull/10361


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org