You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "gianm (via GitHub)" <gi...@apache.org> on 2024/05/14 11:22:15 UTC

[PR] Fix ExpressionPredicateIndexSupplier numeric replace-with-default behavior. (druid)

gianm opened a new pull request, #16448:
URL: https://github.com/apache/druid/pull/16448

   In replace-with-default mode, null numeric values from the index should be interpreted as zeroes by expressions. This makes the index supplier more consistent with the behavior of the selectors created by the expression virtual column.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] Fix ExpressionPredicateIndexSupplier numeric replace-with-default behavior. (druid)

Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm closed pull request #16448: Fix ExpressionPredicateIndexSupplier numeric replace-with-default behavior.
URL: https://github.com/apache/druid/pull/16448


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] Fix ExpressionPredicateIndexSupplier numeric replace-with-default behavior. (druid)

Posted by "cryptoe (via GitHub)" <gi...@apache.org>.
cryptoe merged PR #16448:
URL: https://github.com/apache/druid/pull/16448


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] Fix ExpressionPredicateIndexSupplier numeric replace-with-default behavior. (druid)

Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm commented on PR #16448:
URL: https://github.com/apache/druid/pull/16448#issuecomment-2111236433

   The 4 failures are due to code coverage in SQL-compatible mode. I think we should ignore these, because the relevant new code is only used in the non-SQL-compatible code path.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org