You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by js...@apache.org on 2014/07/24 03:12:51 UTC
webworks commit: CB-5815 cordova not defined when pausing w/o
cordova.js included
Repository: cordova-blackberry
Updated Branches:
refs/heads/master e79df1460 -> 3df35666d
CB-5815 cordova not defined when pausing w/o cordova.js included
Don't call cordova.fireDocumentEvent for pause/resume events
unless cordova object is available
BB10 inactive/active events are mapped to Cordova events,
but they shouldn't trigger an exception if cordova.js isn't included
Project: http://git-wip-us.apache.org/repos/asf/cordova-blackberry/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-blackberry/commit/3df35666
Tree: http://git-wip-us.apache.org/repos/asf/cordova-blackberry/tree/3df35666
Diff: http://git-wip-us.apache.org/repos/asf/cordova-blackberry/diff/3df35666
Branch: refs/heads/master
Commit: 3df35666d51d8ad6da62cee1f36b4c9afe827dc8
Parents: e79df14
Author: Josh Soref <js...@blackberry.com>
Authored: Wed Jul 23 21:08:16 2014 -0400
Committer: Josh Soref <js...@blackberry.com>
Committed: Wed Jul 23 21:11:03 2014 -0400
----------------------------------------------------------------------
framework/lib/framework.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-blackberry/blob/3df35666/framework/lib/framework.js
----------------------------------------------------------------------
diff --git a/framework/lib/framework.js b/framework/lib/framework.js
index 85732dd..a7f7efa 100644
--- a/framework/lib/framework.js
+++ b/framework/lib/framework.js
@@ -24,13 +24,13 @@ var utils = require('./utils'),
pause: {
event: "inactive",
trigger: function () {
- webview.executeJavascript("if (cordova) cordova.fireDocumentEvent('pause')");
+ webview.executeJavascript("if (typeof cordova !== 'undefined') cordova.fireDocumentEvent('pause')");
}
},
resume: {
event: "active",
trigger: function () {
- webview.executeJavascript("if (cordova) cordova.fireDocumentEvent('resume')");
+ webview.executeJavascript("if (typeof cordova !== 'undefined') cordova.fireDocumentEvent('resume')");
}
}
};