You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by aa...@apache.org on 2019/11/25 05:38:34 UTC
[hadoop] branch trunk updated: HADOOP-16717. Remove GenericsUtil
isLog4jLogger dependency on Log4jLoggerAdapter. Contributed by Xieming Li.
This is an automated email from the ASF dual-hosted git repository.
aajisaka pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/trunk by this push:
new da94351 HADOOP-16717. Remove GenericsUtil isLog4jLogger dependency on Log4jLoggerAdapter. Contributed by Xieming Li.
da94351 is described below
commit da9435182a8fccec743406e089325655138d9de8
Author: Akira Ajisaka <aa...@apache.org>
AuthorDate: Mon Nov 25 14:36:27 2019 +0900
HADOOP-16717. Remove GenericsUtil isLog4jLogger dependency on Log4jLoggerAdapter. Contributed by Xieming Li.
---
.../src/main/java/org/apache/hadoop/util/GenericsUtil.java | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericsUtil.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericsUtil.java
index a53096a..0aba348 100644
--- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericsUtil.java
+++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericsUtil.java
@@ -25,7 +25,6 @@ import org.apache.hadoop.classification.InterfaceAudience;
import org.apache.hadoop.classification.InterfaceStability;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import org.slf4j.impl.Log4jLoggerAdapter;
/**
* Contains utility methods for dealing with Java Generics.
@@ -85,6 +84,11 @@ public class GenericsUtil {
return false;
}
Logger log = LoggerFactory.getLogger(clazz);
- return log instanceof Log4jLoggerAdapter;
+ try {
+ Class log4jClass = Class.forName("org.slf4j.impl.Log4jLoggerAdapter");
+ return log4jClass.isInstance(log);
+ } catch (ClassNotFoundException e) {
+ return false;
+ }
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org