You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by msokk <gi...@git.apache.org> on 2015/07/22 21:52:45 UTC

[GitHub] cordova-plugin-geolocation pull request: CB-8826 [iOS 8+] Request ...

GitHub user msokk opened a pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/46

    CB-8826 [iOS 8+] Request WhenInUse permission before Always permission

    First reported here: https://issues.apache.org/jira/browse/CB-8826
    
    Currently the plugin asks for background location first if `NSLocationAlwaysUsageDescription` is in place along with `NSLocationWhenInUseUsageDescription`. Given the current plugin functionality, this is unnecessary and privacy wise disturbing to user.
    
    Apple documentation:
    > Requesting “Always” authorization is discouraged because of the potential negative impacts to user privacy. You should request this level of authorization only when doing so offers a genuine benefit to the user.
    
    This commit allows other plugins to request background permission separately.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/msokk/cordova-plugin-geolocation CB-8826

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-geolocation/pull/46.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #46
    
----
commit 8e7ff11b9a97e923c16eb1b8edbb4eeca9eabe13
Author: Mihkel Sokk <mi...@gmail.com>
Date:   2015-07-22T19:16:43Z

    CB-8826 Check for NSLocationWhenInUseUsageDescription first

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-geolocation pull request: CB-8826 [iOS 8+] Request ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-plugin-geolocation/pull/46


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org