[GitHub] [hive] kgyrtkirk commented on a change in pull request #1902: HIVE-24673: Migrate NegativeCliDriver and NegativeMinimrCliDriver to …

[GitBox <gi...@apache.org>]

kgyrtkirk commented on a change in pull request #1902:
URL: https://github.com/apache/hive/pull/1902#discussion_r568632109



##########
File path: itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java
##########
@@ -348,13 +348,13 @@ public CompareCliConfig() {
     }
   }
 
-  public static class NegativeCliConfig extends AbstractCliConfig {
-    public NegativeCliConfig() {
+  public static class NegativeLlapLocalCliConfig extends AbstractCliConfig {

Review comment:
       after this patch we will have the following llap tests:
   
   * TestMiniLlapLocalCliDriver
   * TestNegativeLlapLocalCliDriver
   * TestMiniLlapCliDriver
   * TestNegativeLlapCliDriver
   
   I'm just saying that instead of adding keywords to the test name we could remove some...nowadays `TestMiniLlapLocalCliDriver` means the same to me as what `TestCliDriver` have been a few years ago
   
   Another interesting thing is the presence of the "Mini" in the name of some of the llap drivers....
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org