You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/22 12:43:35 UTC

[GitHub] [kafka] thake opened a new pull request #9478: Fixed unit test mocks and incorrect required context serdes.

thake opened a new pull request #9478:
URL: https://github.com/apache/kafka/pull/9478


   Fixed an incorrect requireNonNull on the context Serdes introduced with #9338 
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vvcephei commented on pull request #9478: Fixed unit test mocks and incorrect required context serdes.

Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #9478:
URL: https://github.com/apache/kafka/pull/9478#issuecomment-714562224


   Thanks for this, @thake!
   
   I'm wondering if this is the right direction to go here. In a real Streams application, as well as in MockProcessorContext and TopologyTestDriver, the context serdes can never be null, so it seems to be a problem only for EasyMock tests.
   
   It's not that "easy" to begin with to set up an EasyMock of a context for testing Streams components because the set of required interactions is both non-trivial and an internal detail. That's why we offer the MockProcessorContext, which provides default behavior that should be suitable for most tests and still lets you capture and assert the things you'd need to assert.
   
   Have I misunderstood the problem here?
   
   Thanks,
   -John


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vvcephei commented on pull request #9478: Fixed unit test mocks and incorrect required context serdes.

Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #9478:
URL: https://github.com/apache/kafka/pull/9478#issuecomment-714565433


   Sorry, this is getting complicated. I've just realized that this PR is specifically addressing some internal test failures that came up in the 2.6 port: https://github.com/apache/kafka/pull/9467 .
   
   If that's the sole motivation, then I think we can close this PR and instead just fix the tests in https://github.com/apache/kafka/pull/9467
   
   What do you think, @thake ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] thake closed pull request #9478: Fixed unit test mocks and incorrect required context serdes.

Posted by GitBox <gi...@apache.org>.
thake closed pull request #9478:
URL: https://github.com/apache/kafka/pull/9478


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] thake commented on pull request #9478: Fixed unit test mocks and incorrect required context serdes.

Posted by GitBox <gi...@apache.org>.
thake commented on pull request #9478:
URL: https://github.com/apache/kafka/pull/9478#issuecomment-714630476


   You were right. Somehow I thought that the tests were right and that keySerde and valueSerde are nullable. It would really help to have a null safe API description using annotations.
   
   Closing this PR because it addresses a non issue :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vvcephei commented on pull request #9478: Fixed unit test mocks and incorrect required context serdes.

Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #9478:
URL: https://github.com/apache/kafka/pull/9478#issuecomment-717972777


   Thanks @thake , I agree. I think someone proposed to add Nullable/NotNull annotations to the project; I'm not sure what happened to that proposal.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org