You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Caideyipi (via GitHub)" <gi...@apache.org> on 2026/07/29 07:02:17 UTC

[PR] [To dev/1.3] [Pipe] Fix TsFile rate limit accounting (#18344) [iotdb]

Caideyipi opened a new pull request, #18347:
URL: https://github.com/apache/iotdb/pull/18347

   ## Description
   
   Backport #18344 (f3f7d125fe01d0e22ceb2211b942669bd845ca65) to dev/1.3.
   
   - Apply TsFile rate limiting and disk I/O accounting after each read, using the actual number of bytes read.
   - Avoid accounting for EOF reads and over-accounting the final partial chunk across air-gap, SSL sync, sync Thrift, and async Thrift transfer paths.
   - Add unit coverage for async and air-gap TsFile transfer accounting.
   
   The dev/1.3 branch uses the older non-V2 transfer request types, so the AirGap test conflict was resolved by retaining the 1.3 request types while adding the new byte-accounting assertion.
   
   ## Verification
   
   - `mvn spotless:apply -pl iotdb-core/datanode,iotdb-core/node-commons`
   - `mvn -Ddevelocity.off=true test -pl iotdb-core/datanode -Dtest=IoTDBDataRegionAirGapSinkTest,PipeTransferTsFileHandlerRateLimitTest` (3 tests passed)
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added or modified unit tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [To dev/1.3] [Pipe] Fix TsFile rate limit accounting (#18344) [iotdb]

Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #18347:
URL: https://github.com/apache/iotdb/pull/18347


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org