You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2015/12/16 10:34:01 UTC
Re: Review Request 39492: Added status endpoint for quota master
endpoint.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/
-----------------------------------------------------------
(Updated Dec. 16, 2015, 9:34 a.m.)
Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
Bugs: MESOS-4013
https://issues.apache.org/jira/browse/MESOS-4013
Repository: mesos
Description
-------
Added status handling for quota master endpoint.
Diffs
-----
include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d
src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80
src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f
Diff: https://reviews.apache.org/r/39492/diff/
Testing
-------
Tests are in next Review.
Thanks,
Joerg Schad
Re: Review Request 39492: Added status endpoint for quota master
endpoint.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review111565
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39211, 39018, 39102, 36913, 38059, 39285, 38110, 40342, 40351, 40396, 39223, 39492]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 21, 2015, 7:02 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2015, 7:02 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
>
>
> Bugs: MESOS-4013
> https://issues.apache.org/jira/browse/MESOS-4013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added status handling for quota master endpoint.
>
>
> Diffs
> -----
>
> include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed
> src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526
> src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
>
> Diff: https://reviews.apache.org/r/39492/diff/
>
>
> Testing
> -------
>
> Tests are in next Review.
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 39492: Added status endpoint for quota master
endpoint.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review111596
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 十二月 22, 2015, 9:40 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
>
> (Updated 十二月 22, 2015, 9:40 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
>
>
> Bugs: MESOS-4013
> https://issues.apache.org/jira/browse/MESOS-4013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added status handling for quota master endpoint.
>
>
> Diffs
> -----
>
> include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed
> src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526
> src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
>
> Diff: https://reviews.apache.org/r/39492/diff/
>
>
> Testing
> -------
>
> Tests are in Review 39614.
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 39492: Added status endpoint for quota master
endpoint.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review112665
-----------------------------------------------------------
Ship it!
- Joris Van Remoortere
On Dec. 22, 2015, 9:40 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2015, 9:40 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
>
>
> Bugs: MESOS-4013
> https://issues.apache.org/jira/browse/MESOS-4013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added status handling for quota master endpoint.
>
>
> Diffs
> -----
>
> include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed
> src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526
> src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
>
> Diff: https://reviews.apache.org/r/39492/diff/
>
>
> Testing
> -------
>
> Tests are in Review 39614.
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 39492: Added status endpoint for quota master
endpoint.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/
-----------------------------------------------------------
(Updated Dec. 22, 2015, 9:40 a.m.)
Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
Bugs: MESOS-4013
https://issues.apache.org/jira/browse/MESOS-4013
Repository: mesos
Description
-------
Added status handling for quota master endpoint.
Diffs
-----
include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed
src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526
src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
Diff: https://reviews.apache.org/r/39492/diff/
Testing
-------
Tests are in Review 39614.
Thanks,
Joerg Schad
Re: Review Request 39492: Added status endpoint for quota master
endpoint.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/
-----------------------------------------------------------
(Updated Dec. 22, 2015, 8:38 a.m.)
Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
Bugs: MESOS-4013
https://issues.apache.org/jira/browse/MESOS-4013
Repository: mesos
Description
-------
Added status handling for quota master endpoint.
Diffs
-----
include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed
src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526
src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
Diff: https://reviews.apache.org/r/39492/diff/
Testing (updated)
-------
Tests are in Review 39614.
Thanks,
Joerg Schad
Re: Review Request 39492: Added status endpoint for quota master
endpoint.
Posted by Joerg Schad <jo...@mesosphere.io>.
> On Dec. 21, 2015, 10:22 p.m., Guangya Liu wrote:
> > I assume that you will have another RR to cover the unit test, right?
Yes, just updated the description (as we removed the dependency and there is no next review anymore). Thanks!
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review111547
-----------------------------------------------------------
On Dec. 22, 2015, 8:38 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2015, 8:38 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
>
>
> Bugs: MESOS-4013
> https://issues.apache.org/jira/browse/MESOS-4013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added status handling for quota master endpoint.
>
>
> Diffs
> -----
>
> include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed
> src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526
> src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
>
> Diff: https://reviews.apache.org/r/39492/diff/
>
>
> Testing
> -------
>
> Tests are in Review 39614.
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 39492: Added status endpoint for quota master
endpoint.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review111547
-----------------------------------------------------------
Ship it!
I assume that you will have another RR to cover the unit test, right?
- Guangya Liu
On 十二月 21, 2015, 7:02 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
>
> (Updated 十二月 21, 2015, 7:02 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
>
>
> Bugs: MESOS-4013
> https://issues.apache.org/jira/browse/MESOS-4013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added status handling for quota master endpoint.
>
>
> Diffs
> -----
>
> include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed
> src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526
> src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
>
> Diff: https://reviews.apache.org/r/39492/diff/
>
>
> Testing
> -------
>
> Tests are in next Review.
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 39492: Added status endpoint for quota master
endpoint.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/
-----------------------------------------------------------
(Updated Dec. 21, 2015, 7:02 p.m.)
Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
Changes
-------
Adressed comments.
Bugs: MESOS-4013
https://issues.apache.org/jira/browse/MESOS-4013
Repository: mesos
Description
-------
Added status handling for quota master endpoint.
Diffs (updated)
-----
include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed
src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526
src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
Diff: https://reviews.apache.org/r/39492/diff/
Testing
-------
Tests are in next Review.
Thanks,
Joerg Schad
Re: Review Request 39492: Added status endpoint for quota master
endpoint.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review111507
-----------------------------------------------------------
Ship it!
src/master/master.hpp (line 945)
<https://reviews.apache.org/r/39492/#comment171708>
"quota settings" sounds like a new term we haven't used before. Let's be repetitive, but predictable. How about "Returns a list of set quotas".
If you have something in mind how the response will be extended, feel free to add a `TODO`.
src/master/quota_handler.cpp (line 474)
<https://reviews.apache.org/r/39492/#comment171709>
s/entry/an entry?
- Alexander Rukletsov
On Dec. 21, 2015, 2:56 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2015, 2:56 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
>
>
> Bugs: MESOS-4013
> https://issues.apache.org/jira/browse/MESOS-4013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added status handling for quota master endpoint.
>
>
> Diffs
> -----
>
> include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed
> src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526
> src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
>
> Diff: https://reviews.apache.org/r/39492/diff/
>
>
> Testing
> -------
>
> Tests are in next Review.
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 39492: Added status endpoint for quota master
endpoint.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/
-----------------------------------------------------------
(Updated Dec. 21, 2015, 2:56 p.m.)
Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
Bugs: MESOS-4013
https://issues.apache.org/jira/browse/MESOS-4013
Repository: mesos
Description
-------
Added status handling for quota master endpoint.
Diffs (updated)
-----
include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed
src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526
src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
Diff: https://reviews.apache.org/r/39492/diff/
Testing
-------
Tests are in next Review.
Thanks,
Joerg Schad