You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/09/04 04:54:21 UTC

Review Request 38118: Fix webui display problems when starting lots of tasks with small cpu value.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38118/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Bugs: MESOS-2635
    https://issues.apache.org/jira/browse/MESOS-2635


Repository: mesos


Description
-------

Fix webui display problems when starting lots of tasks with small cpu value.


Diffs
-----

  src/webui/master/static/home.html ce8ca192235c224715c01fef0b8ddb187dc0a827 
  src/webui/master/static/js/controllers.js 3445028138fd621d0e3a5427668c5eca7db5224f 

Diff: https://reviews.apache.org/r/38118/diff/


Testing
-------

manually test


Thanks,

haosdent huang

Re: Review Request 38118: Fix webui display problems when starting lots of tasks with small cpu value.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38118/#review97748
-----------------------------------------------------------

Ship it!


Ship It!

- Kapil Arya


On Sept. 3, 2015, 10:54 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38118/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2015, 10:54 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-2635
>     https://issues.apache.org/jira/browse/MESOS-2635
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix webui display problems when starting lots of tasks with small cpu value.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/home.html ce8ca192235c224715c01fef0b8ddb187dc0a827 
>   src/webui/master/static/js/controllers.js 3445028138fd621d0e3a5427668c5eca7db5224f 
> 
> Diff: https://reviews.apache.org/r/38118/diff/
> 
> 
> Testing
> -------
> 
> manually test
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38118: Fix webui display problems when starting lots of tasks with small cpu value.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38118/#review97737
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38118]

All tests passed.

- Mesos ReviewBot


On Sept. 4, 2015, 2:54 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38118/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2015, 2:54 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-2635
>     https://issues.apache.org/jira/browse/MESOS-2635
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix webui display problems when starting lots of tasks with small cpu value.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/home.html ce8ca192235c224715c01fef0b8ddb187dc0a827 
>   src/webui/master/static/js/controllers.js 3445028138fd621d0e3a5427668c5eca7db5224f 
> 
> Diff: https://reviews.apache.org/r/38118/diff/
> 
> 
> Testing
> -------
> 
> manually test
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38118: Fix webui display problems when starting lots of tasks with small cpu value.

Posted by haosdent huang <ha...@gmail.com>.

> On Sept. 4, 2015, 3:32 p.m., Michael Park wrote:
> > src/webui/master/static/home.html, line 101
> > <https://reviews.apache.org/r/38118/diff/1/?file=1063733#file1063733line101>
> >
> >     Does `number:4` not give us what we want here?
> 
> haosdent huang wrote:
>     could not, if number is small than "0.000001", use number:4 here would become "0.0000". For normal value, "4.2" also would become "4.2000".

@karya @mcypark Do you know anyone also could help review this and https://reviews.apache.org/r/38056/ ? Most code in controller.js are written by Ross Allen, but seems he is not active any more now.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38118/#review97759
-----------------------------------------------------------


On Sept. 4, 2015, 12:54 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38118/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2015, 12:54 p.m.)
> 
> 
> Review request for mesos, Kapil Arya and Michael Park.
> 
> 
> Bugs: MESOS-2635
>     https://issues.apache.org/jira/browse/MESOS-2635
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix webui display problems when starting lots of tasks with small cpu value.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/home.html ce8ca192235c224715c01fef0b8ddb187dc0a827 
>   src/webui/master/static/js/controllers.js 3445028138fd621d0e3a5427668c5eca7db5224f 
> 
> Diff: https://reviews.apache.org/r/38118/diff/
> 
> 
> Testing
> -------
> 
> manually test
> 
> * Before fix
> ![before_fix](https://issues.apache.org/jira/secure/attachment/12754133/fixed_before.png)
> * After fix
> ![after_fix](https://issues.apache.org/jira/secure/attachment/12754132/fixed_after.png)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38118: Fix webui display problems when starting lots of tasks with small cpu value.

Posted by haosdent huang <ha...@gmail.com>.

> On Sept. 4, 2015, 3:32 p.m., Michael Park wrote:
> > src/webui/master/static/home.html, line 101
> > <https://reviews.apache.org/r/38118/diff/1/?file=1063733#file1063733line101>
> >
> >     Does `number:4` not give us what we want here?

could not, if number is small than "0.000001", use number:4 here would become "0.0000". For normal value, "4.2" also would become "4.2000".


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38118/#review97759
-----------------------------------------------------------


On Sept. 4, 2015, 12:54 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38118/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2015, 12:54 p.m.)
> 
> 
> Review request for mesos, Kapil Arya and Michael Park.
> 
> 
> Bugs: MESOS-2635
>     https://issues.apache.org/jira/browse/MESOS-2635
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix webui display problems when starting lots of tasks with small cpu value.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/home.html ce8ca192235c224715c01fef0b8ddb187dc0a827 
>   src/webui/master/static/js/controllers.js 3445028138fd621d0e3a5427668c5eca7db5224f 
> 
> Diff: https://reviews.apache.org/r/38118/diff/
> 
> 
> Testing
> -------
> 
> manually test
> 
> * Before fix
> ![before_fix](https://issues.apache.org/jira/secure/attachment/12754133/fixed_before.png)
> * After fix
> ![after_fix](https://issues.apache.org/jira/secure/attachment/12754132/fixed_after.png)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38118: Fix webui display problems when starting lots of tasks with small cpu value.

Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38118/#review97759
-----------------------------------------------------------



src/webui/master/static/home.html (line 101)
<https://reviews.apache.org/r/38118/#comment153776>

    Does `number:4` not give us what we want here?


- Michael Park


On Sept. 4, 2015, 12:54 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38118/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2015, 12:54 p.m.)
> 
> 
> Review request for mesos, Kapil Arya and Michael Park.
> 
> 
> Bugs: MESOS-2635
>     https://issues.apache.org/jira/browse/MESOS-2635
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix webui display problems when starting lots of tasks with small cpu value.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/home.html ce8ca192235c224715c01fef0b8ddb187dc0a827 
>   src/webui/master/static/js/controllers.js 3445028138fd621d0e3a5427668c5eca7db5224f 
> 
> Diff: https://reviews.apache.org/r/38118/diff/
> 
> 
> Testing
> -------
> 
> manually test
> 
> * Before fix
> ![before_fix](https://issues.apache.org/jira/secure/attachment/12754133/fixed_before.png)
> * After fix
> ![after_fix](https://issues.apache.org/jira/secure/attachment/12754132/fixed_after.png)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38118: Fix webui display problems when starting lots of tasks with small cpu value.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38118/
-----------------------------------------------------------

(Updated Sept. 4, 2015, 12:54 p.m.)


Review request for mesos, Kapil Arya and Michael Park.


Changes
-------

Attach test images


Bugs: MESOS-2635
    https://issues.apache.org/jira/browse/MESOS-2635


Repository: mesos


Description
-------

Fix webui display problems when starting lots of tasks with small cpu value.


Diffs
-----

  src/webui/master/static/home.html ce8ca192235c224715c01fef0b8ddb187dc0a827 
  src/webui/master/static/js/controllers.js 3445028138fd621d0e3a5427668c5eca7db5224f 

Diff: https://reviews.apache.org/r/38118/diff/


Testing (updated)
-------

manually test

* Before fix
![before_fix](https://issues.apache.org/jira/secure/attachment/12754133/fixed_before.png)
* After fix
![after_fix](https://issues.apache.org/jira/secure/attachment/12754132/fixed_after.png)


Thanks,

haosdent huang