You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2023/01/07 10:38:38 UTC
[GitHub] [netbeans] tbw777 opened a new pull request, #5238: nbbuild dir: removed unessesary old forms of Integer type
tbw777 opened a new pull request, #5238:
URL: https://github.com/apache/netbeans/pull/5238
Changed boxing/autoboxing with Integer()/valueOf()/intValue() to raw int values or parseInt(some string)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5238: nbbuild dir: removed unessesary old forms of Integer type
Posted by GitBox <gi...@apache.org>.
tbw777 commented on PR #5238:
URL: https://github.com/apache/netbeans/pull/5238#issuecomment-1374846088
@mbien ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5238: nbbuild dir: removed unessesary old forms of Integer type
Posted by GitBox <gi...@apache.org>.
tbw777 commented on PR #5238:
URL: https://github.com/apache/netbeans/pull/5238#issuecomment-1374831198
@mbien
I'l try some small PR, write me is it good.
A reason: blocking PR queue is low my motivation to do anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on pull request #5238: nbbuild dir: removed unessesary old forms of Integer type
Posted by GitBox <gi...@apache.org>.
BradWalker commented on PR #5238:
URL: https://github.com/apache/netbeans/pull/5238#issuecomment-1396405439
> > @mbien can i post now one new PR or continue wait? )
>
> Flooding the project with mass change PRs is a good way to be ignored. Let the current PRs be drained and then go on. Remember: we are not paid to do this and I'm more inclined to look at PRs fixing actual problems and not just mechanical cleanups.
Hey @tbw777, let provide some context here.. I started out by cleaning up a lot of source code "low hanging" fruit. Stuff that was really easy to review. So I understand the excitement.
But, remember people have to review this. And what might seem trivial or straight-forward to you is work for others. That's not to say your work doesn't have meaning or value. It does have value and people want to include it. So just be aware there is work on our end to get this into the system.
So, pace yourself. We want you involved for the long term. Don't burn yourself out. Let us catch up to your enthusiasm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5238: nbbuild dir: removed unessesary old forms of Integer type
Posted by GitBox <gi...@apache.org>.
tbw777 commented on PR #5238:
URL: https://github.com/apache/netbeans/pull/5238#issuecomment-1377684011
@mbien can i post now one new PR or continue wait? )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5238: nbbuild dir: removed unessesary old forms of Integer type
Posted by GitBox <gi...@apache.org>.
tbw777 commented on PR #5238:
URL: https://github.com/apache/netbeans/pull/5238#issuecomment-1377848749
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien merged pull request #5238: nbbuild dir: removed unessesary old forms of Integer type
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #5238:
URL: https://github.com/apache/netbeans/pull/5238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5238: nbbuild dir: removed unessesary old forms of Integer type
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #5238:
URL: https://github.com/apache/netbeans/pull/5238#issuecomment-1374843378
@tbw777 doing larger PRs is fine. Just not crazy large. Someone has to review the PR somehow.
So it depends how complex a PR is. If it does something simple in 200 files.. it might be ok. You can also put multiple commits into a single PR which makes reviewing also easier.
This one for example is too big #5203 since merging this will cause too many conflicts at once to other PRs. This is better #5189.
Also keep in mind that PRs uses apache resources since CI has to build and test a lot - too many PRs is also bad if they can be combined into medium-sized PRs.
So please don't open too many PRs since we have to merge some first. You can work with your clone of netbeans without creating PRs, and once we can merge more you simply open more if you want. It can take some time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5238: nbbuild dir: removed unessesary old forms of Integer type
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #5238:
URL: https://github.com/apache/netbeans/pull/5238#issuecomment-1374436386
@tbw777 thats enough PRs for now. lets wait a bit till we can merge a few.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5238: nbbuild dir: removed unessesary old forms of Integer type
Posted by GitBox <gi...@apache.org>.
tbw777 commented on PR #5238:
URL: https://github.com/apache/netbeans/pull/5238#issuecomment-1374436456
@mbien
OK!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #5238: nbbuild dir: removed unessesary old forms of Integer type
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #5238:
URL: https://github.com/apache/netbeans/pull/5238#issuecomment-1377797121
> @mbien can i post now one new PR or continue wait? )
Flooding the project with mass change PRs is a good way to be ignored. Let the current PRs be drained and then go on. Remember: we are not paid to do this and I'm more inclined to look at PRs fixing actual problems and not just mechanical cleanups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists