Re: [PR] fix(ios): improve using `CDVSettingsDictionary` in older cordova-ios versions [cordova-plugin-inappbrowser]

["dpogue (via GitHub)" <gi...@apache.org>]

dpogue commented on code in PR #1105:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/1105#discussion_r2771247592


##########
src/ios/CDVWKInAppBrowser.h:
##########
@@ -20,11 +20,15 @@
 #import <Cordova/CDVPlugin.h>
 #import <Cordova/CDVInvokedUrlCommand.h>
 #ifdef __CORDOVA_8_0_0
-    // cordova-ios 8 introduced CDVSettingsDictionary, which should be used instead of NSDictionary+CordovaPreferences
+    // cordova-ios 8 introduced CDVSettingsDictionary, which should be used
+    // instead of NSDictionary+CordovaPreferences
     #import <Cordova/CDVSettingsDictionary.h>
 #else

Review Comment:
   We don't need this import because CDVPlugin.h already pulls in CDVSettingsDictionary.h



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org