[jira] [Updated] (LUCENE-5277) Modify FixedBitSet copy constructor to take numBits to allow grow/shrink the new bitset

["Shai Erera (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shai Erera updated LUCENE-5277:
-------------------------------

    Attachment: LUCENE-5277.patch

Patch adds the extra parameter and tests. I think it's ok to not deprecate this ctor and add another one since it's not used in Lucene code, and I imagine it's quite expert to do + there's an easy alternative (call clone()). We can also add size() to return numBits (actually I think it's useful to add that anyway?)

> Modify FixedBitSet copy constructor to take numBits to allow grow/shrink the new bitset
> ---------------------------------------------------------------------------------------
>
>                 Key: LUCENE-5277
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5277
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/index
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>         Attachments: LUCENE-5277.patch
>
>
> FixedBitSet copy constructor is redundant the way it is now -- one can call FBS.clone() to achieve that (and indeed, no code in Lucene calls this ctor). I think it will be useful to add a numBits parameter to that method to allow growing/shrinking the new bitset, while copying all relevant bits from the passed one.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org