You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Niclas Hedhman (JIRA)" <ji...@apache.org> on 2006/05/15 07:11:05 UTC

[jira] Created: (FELIX-73) whitespace removal in certain Manifest entries in maven-osgi-plugin

whitespace removal in certain Manifest entries in maven-osgi-plugin
-------------------------------------------------------------------

         Key: FELIX-73
         URL: http://issues.apache.org/jira/browse/FELIX-73
     Project: Felix
        Type: Improvement

    Versions: 0.8.0    
    Reporter: Niclas Hedhman
    Priority: Minor


I find it somewhat annoying that configuration of the manifest in the pom.xml must contain elements without whitespace, or it will not work. For instance;

One can not write
<exportPackages>
  org.hedhman.habba,
  org.hedhman.zout,
  org.hedhman.plouk,
  org.hedhman.tounga
</exportPackages>

and must write them in a single line.

By removal of all whitespace in some of the manifest entries, one can oversome this very easily.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (FELIX-73) whitespace removal in certain Manifest entries in maven-osgi-plugin

Posted by "Niclas Hedhman (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FELIX-73?page=all ]

Niclas Hedhman updated FELIX-73:
--------------------------------

    Attachment: OsgiJarMojo.java.patch

 o an <excludeImport> tag, which is a comma-separated list of packages NOT to
   import.

 o Added print out of the references in Maven debug mode (-X)

 o Added a system property "osgi.whoUses", so that one can do;
      mvn -DwhoUses=junit.framework install
   and get a list of packages that refers to it.

 o Trims the whitespaces in many config tags.



> whitespace removal in certain Manifest entries in maven-osgi-plugin
> -------------------------------------------------------------------
>
>          Key: FELIX-73
>          URL: http://issues.apache.org/jira/browse/FELIX-73
>      Project: Felix
>         Type: Improvement

>   Components: Maven OSGi Plugin
>     Versions: 0.8.0
>     Reporter: Niclas Hedhman
>     Priority: Minor
>  Attachments: OsgiJarMojo.java.patch, maven-osgi-plugin.patch
>
> I find it somewhat annoying that configuration of the manifest in the pom.xml must contain elements without whitespace, or it will not work. For instance;
> One can not write
> <exportPackages>
>   org.hedhman.habba,
>   org.hedhman.zout,
>   org.hedhman.plouk,
>   org.hedhman.tounga
> </exportPackages>
> and must write them in a single line.
> By removal of all whitespace in some of the manifest entries, one can oversome this very easily.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (FELIX-73) whitespace removal in certain Manifest entries in maven-osgi-plugin

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FELIX-73?page=all ]

Richard S. Hall updated FELIX-73:
---------------------------------

    Component: Maven OSGi Plugin

> whitespace removal in certain Manifest entries in maven-osgi-plugin
> -------------------------------------------------------------------
>
>          Key: FELIX-73
>          URL: http://issues.apache.org/jira/browse/FELIX-73
>      Project: Felix
>         Type: Improvement

>   Components: Maven OSGi Plugin
>     Versions: 0.8.0
>     Reporter: Niclas Hedhman
>     Priority: Minor
>  Attachments: maven-osgi-plugin.patch
>
> I find it somewhat annoying that configuration of the manifest in the pom.xml must contain elements without whitespace, or it will not work. For instance;
> One can not write
> <exportPackages>
>   org.hedhman.habba,
>   org.hedhman.zout,
>   org.hedhman.plouk,
>   org.hedhman.tounga
> </exportPackages>
> and must write them in a single line.
> By removal of all whitespace in some of the manifest entries, one can oversome this very easily.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (FELIX-73) whitespace removal in certain Manifest entries in maven-osgi-plugin

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/FELIX-73?page=comments#action_12402281 ] 

Richard S. Hall commented on FELIX-73:
--------------------------------------

We have a patch from Peter Kriens for the plugin that appears to fix a least some of this issue along with adding nice features like import-package header generation among others. We are simply waiting for Apache to report receiving the ICLA...there apparently have been some fax quality issues. Once it is checked in, perhaps you can recheck your issues and see if they are still relevant, some might be. We will leave this issue open until then...hopefully we will resolve this shortly.

> whitespace removal in certain Manifest entries in maven-osgi-plugin
> -------------------------------------------------------------------
>
>          Key: FELIX-73
>          URL: http://issues.apache.org/jira/browse/FELIX-73
>      Project: Felix
>         Type: Improvement

>     Versions: 0.8.0
>     Reporter: Niclas Hedhman
>     Priority: Minor
>  Attachments: maven-osgi-plugin.patch
>
> I find it somewhat annoying that configuration of the manifest in the pom.xml must contain elements without whitespace, or it will not work. For instance;
> One can not write
> <exportPackages>
>   org.hedhman.habba,
>   org.hedhman.zout,
>   org.hedhman.plouk,
>   org.hedhman.tounga
> </exportPackages>
> and must write them in a single line.
> By removal of all whitespace in some of the manifest entries, one can oversome this very easily.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (FELIX-73) whitespace removal in certain Manifest entries in maven-osgi-plugin

Posted by "Niclas Hedhman (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FELIX-73?page=all ]

Niclas Hedhman updated FELIX-73:
--------------------------------

    Attachment: OsgiJarMojo.java.patch2

Mistake sneaked into the previous patch. Only use patch2 for this file.

> whitespace removal in certain Manifest entries in maven-osgi-plugin
> -------------------------------------------------------------------
>
>          Key: FELIX-73
>          URL: http://issues.apache.org/jira/browse/FELIX-73
>      Project: Felix
>         Type: Improvement

>   Components: Maven OSGi Plugin
>     Versions: 0.8.0
>     Reporter: Niclas Hedhman
>     Priority: Minor
>  Attachments: OsgiJarMojo.java.patch, OsgiJarMojo.java.patch2, OsgiManifest.java.patch, maven-osgi-plugin.patch
>
> I find it somewhat annoying that configuration of the manifest in the pom.xml must contain elements without whitespace, or it will not work. For instance;
> One can not write
> <exportPackages>
>   org.hedhman.habba,
>   org.hedhman.zout,
>   org.hedhman.plouk,
>   org.hedhman.tounga
> </exportPackages>
> and must write them in a single line.
> By removal of all whitespace in some of the manifest entries, one can oversome this very easily.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (FELIX-73) whitespace removal in certain Manifest entries in maven-osgi-plugin

Posted by "Niclas Hedhman (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FELIX-73?page=all ]

Niclas Hedhman updated FELIX-73:
--------------------------------

    Attachment: maven-osgi-plugin.patch

Provided a patch which does this for 
 export package
 export service
 import package
 dynamic import package
 fragment host
 require bundle
 bundle symbolic name
 bundle activator

Not sure if this is the right set, need to cross-ref with the spec to be exhaustive.

> whitespace removal in certain Manifest entries in maven-osgi-plugin
> -------------------------------------------------------------------
>
>          Key: FELIX-73
>          URL: http://issues.apache.org/jira/browse/FELIX-73
>      Project: Felix
>         Type: Improvement

>     Versions: 0.8.0
>     Reporter: Niclas Hedhman
>     Priority: Minor
>  Attachments: maven-osgi-plugin.patch
>
> I find it somewhat annoying that configuration of the manifest in the pom.xml must contain elements without whitespace, or it will not work. For instance;
> One can not write
> <exportPackages>
>   org.hedhman.habba,
>   org.hedhman.zout,
>   org.hedhman.plouk,
>   org.hedhman.tounga
> </exportPackages>
> and must write them in a single line.
> By removal of all whitespace in some of the manifest entries, one can oversome this very easily.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (FELIX-73) whitespace removal in certain Manifest entries in maven-osgi-plugin

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FELIX-73?page=all ]
     
Richard S. Hall resolved FELIX-73:
----------------------------------

    Resolution: Fixed

I have incorporated Niclas' patch modulo some minor changes:

   osgi.whoUses ==> osgi.references
   excludeImport ==> ignorePackage


> whitespace removal in certain Manifest entries in maven-osgi-plugin
> -------------------------------------------------------------------
>
>          Key: FELIX-73
>          URL: http://issues.apache.org/jira/browse/FELIX-73
>      Project: Felix
>         Type: Improvement

>   Components: Maven OSGi Plugin
>     Versions: 0.8.0
>     Reporter: Niclas Hedhman
>     Priority: Minor
>  Attachments: OsgiJarMojo.java.patch, OsgiJarMojo.java.patch2, OsgiManifest.java.patch, maven-osgi-plugin.patch
>
> I find it somewhat annoying that configuration of the manifest in the pom.xml must contain elements without whitespace, or it will not work. For instance;
> One can not write
> <exportPackages>
>   org.hedhman.habba,
>   org.hedhman.zout,
>   org.hedhman.plouk,
>   org.hedhman.tounga
> </exportPackages>
> and must write them in a single line.
> By removal of all whitespace in some of the manifest entries, one can oversome this very easily.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (FELIX-73) whitespace removal in certain Manifest entries in maven-osgi-plugin

Posted by "Niclas Hedhman (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FELIX-73?page=all ]

Niclas Hedhman updated FELIX-73:
--------------------------------

    Attachment: OsgiManifest.java.patch

Used together with the OsgiJarMojo.java.patch

First patch submitted is incorporated in this one.

> whitespace removal in certain Manifest entries in maven-osgi-plugin
> -------------------------------------------------------------------
>
>          Key: FELIX-73
>          URL: http://issues.apache.org/jira/browse/FELIX-73
>      Project: Felix
>         Type: Improvement

>   Components: Maven OSGi Plugin
>     Versions: 0.8.0
>     Reporter: Niclas Hedhman
>     Priority: Minor
>  Attachments: OsgiJarMojo.java.patch, OsgiManifest.java.patch, maven-osgi-plugin.patch
>
> I find it somewhat annoying that configuration of the manifest in the pom.xml must contain elements without whitespace, or it will not work. For instance;
> One can not write
> <exportPackages>
>   org.hedhman.habba,
>   org.hedhman.zout,
>   org.hedhman.plouk,
>   org.hedhman.tounga
> </exportPackages>
> and must write them in a single line.
> By removal of all whitespace in some of the manifest entries, one can oversome this very easily.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (FELIX-73) whitespace removal in certain Manifest entries in maven-osgi-plugin

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-73?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard S. Hall closed FELIX-73.
--------------------------------


> whitespace removal in certain Manifest entries in maven-osgi-plugin
> -------------------------------------------------------------------
>
>                 Key: FELIX-73
>                 URL: https://issues.apache.org/jira/browse/FELIX-73
>             Project: Felix
>          Issue Type: Improvement
>          Components: Maven Plugin
>    Affects Versions: 0.8.0
>            Reporter: Niclas Hedhman
>            Priority: Minor
>         Attachments: maven-osgi-plugin.patch, OsgiJarMojo.java.patch, OsgiJarMojo.java.patch2, OsgiManifest.java.patch
>
>
> I find it somewhat annoying that configuration of the manifest in the pom.xml must contain elements without whitespace, or it will not work. For instance;
> One can not write
> <exportPackages>
>   org.hedhman.habba,
>   org.hedhman.zout,
>   org.hedhman.plouk,
>   org.hedhman.tounga
> </exportPackages>
> and must write them in a single line.
> By removal of all whitespace in some of the manifest entries, one can oversome this very easily.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.