You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/09 08:14:09 UTC

[GitHub] [tvm] apeskov commented on a diff in pull request #11513: [BYOC][DNNL] Improve performance of DNNL BYOC dense operator

apeskov commented on code in PR #11513:
URL: https://github.com/apache/tvm/pull/11513#discussion_r893206356


##########
src/relay/backend/contrib/dnnl/codegen.cc:
##########
@@ -507,6 +540,9 @@ class DNNLJSONSerializer : public backend::contrib::JSONSerializer {
         std::vector<std::string> op_list = ParsingOpList(name);
         call = GetRootCall(fn->body.as<CallNode>(), op_list.size() - 1, op_list);
         ICHECK(call->op.as<OpNode>()) << "Not op node";
+      } else if (name.find("gelu") != std::string::npos) {

Review Comment:
   Minor objection. GELU may be fused not only with dense. I see that you care only about BERT like topologies and there is no other real topologies using that activation. But in general that is not fully correct.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org