You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/17 16:03:43 UTC
[GitHub] [spark] viirya commented on a change in pull request #29771: [SPARK-32635][SQL] Fix foldable propagation
viirya commented on a change in pull request #29771:
URL: https://github.com/apache/spark/pull/29771#discussion_r490368235
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
##########
@@ -2555,6 +2555,18 @@ class DataFrameSuite extends QueryTest
val df = Seq(0.0 -> -0.0).toDF("pos", "neg")
checkAnswer(df.select($"pos" > $"neg"), Row(false))
}
+
+ test("SPARK-32635: Replace references with foldables coming only from the node's children") {
+ val a = Seq("1").toDF("col1").withColumn("col2", lit("1"))
+ val b = Seq("2").toDF("col1").withColumn("col2", lit("2"))
+ val aub = a.union(b)
+ val c = aub.filter($"col1" === "2").cache()
+ val d = Seq("2").toDF( "col4")
Review comment:
nit: extra space before "col4"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org