You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "zpinto (via GitHub)" <gi...@apache.org> on 2024/09/17 21:12:54 UTC
[PR] Pin netty_codec to higher version to address vulnerability [helix]
zpinto opened a new pull request, #2924:
URL: https://github.com/apache/helix/pull/2924
### Issues
- [x] Pin netty_codec to higher version to address vulnerability
### Description
Fix vulnerability:
```
The Bzip2 decompression decoder function doesn't allow setting size restrictions on the decompressed output data (which affects the allocation size used during decompression).
All users of Bzip2Decoder are affected. The malicious input can trigger an OOME and so a DoS attack
```
### Tests
NA
### Changes that Break Backward Compatibility (Optional)
NA
### Documentation (Optional)
NA
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
Re: [PR] Pin netty_codec to higher version to address vulnerability [helix]
Posted by "zpinto (via GitHub)" <gi...@apache.org>.
zpinto commented on PR #2924:
URL: https://github.com/apache/helix/pull/2924#issuecomment-2357291909
Was not able to reproduce issue with the failed test in CI. Likely flaky.
Locally ran 5 times:
```
➜ helix git:(zpinto/pin_netty_codec) ./scripts/runSingleTest.sh TestAutoRebalanceStrategy#simpleMasterSlaveTest 5
Running test on TestAutoRebalanceStrategy#simpleMasterSlaveTest in component helix-core for 5 times.
======================================================================
Attempt 1 TestAutoRebalanceStrategy#simpleMasterSlaveTest
======================================================================
======================================================================
Attempt 2 TestAutoRebalanceStrategy#simpleMasterSlaveTest
======================================================================
======================================================================
Attempt 3 TestAutoRebalanceStrategy#simpleMasterSlaveTest
======================================================================
======================================================================
Attempt 4 TestAutoRebalanceStrategy#simpleMasterSlaveTest
======================================================================
======================================================================
Attempt 5 TestAutoRebalanceStrategy#simpleMasterSlaveTest
======================================================================
```
This PR is ready to be merged.
Final commit message:
Pin netty-codec to higher version to address security vulnerability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
Re: [PR] Pin netty_codec to higher version to address vulnerability [helix]
Posted by "xyuanlu (via GitHub)" <gi...@apache.org>.
xyuanlu merged PR #2924:
URL: https://github.com/apache/helix/pull/2924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org