You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Kirk Lund <ki...@gmail.com> on 2015/11/02 22:57:38 UTC
Review Request 39879: Add gemfire-common and @Experimental annotation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39879/
-----------------------------------------------------------
Review request for geode, Anthony Baker, William Markito, and Mark Bretl.
Bugs: GEODE-328
https://issues.apache.org/jira/browse/GEODE-328
Repository: geode
Description
-------
Add new gemfire-common project containing code for Experimental annotation under main and a UnitTest under test.
Add gemfire-common to gemfire-assembly for publishing.
Add dependency on gemfire-common to gemfire-core, gemfire-rebalancer, and gemfire-web.
Diffs
-----
gemfire-assembly/build.gradle b351729
gemfire-common/build.gradle PRE-CREATION
gemfire-common/src/main/java/com/gemstone/gemfire/annotations/Experimental.java PRE-CREATION
gemfire-common/src/test/java/com/gemstone/gemfire/annotations/ExperimentalJUnitTest.java PRE-CREATION
gemfire-common/src/test/java/com/gemstone/gemfire/annotations/experimentalpackage/ClassInExperimentalPackage.java PRE-CREATION
gemfire-common/src/test/java/com/gemstone/gemfire/annotations/experimentalpackage/package-info.java PRE-CREATION
gemfire-common/src/test/java/com/gemstone/gemfire/experimental/nonexperimentalpackage/ClassInNonExperimentalPackage.java PRE-CREATION
gemfire-common/src/test/java/com/gemstone/gemfire/experimental/nonexperimentalpackage/package-info.java PRE-CREATION
gemfire-core/build.gradle 1c17474
gemfire-rebalancer/build.gradle d87dd58
gemfire-web/build.gradle f0de25a
settings.gradle 4b2da7b
Diff: https://reviews.apache.org/r/39879/diff/
Testing
-------
clean build and unit testing of the new annotation
Thanks,
Kirk Lund
Re: Review Request 39879: Add gemfire-common and @Experimental
annotation
Posted by William Markito <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39879/#review104826
-----------------------------------------------------------
Ship it!
Ship It!
- William Markito
On Nov. 2, 2015, 9:57 p.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39879/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 9:57 p.m.)
>
>
> Review request for geode, Anthony Baker, William Markito, and Mark Bretl.
>
>
> Bugs: GEODE-328
> https://issues.apache.org/jira/browse/GEODE-328
>
>
> Repository: geode
>
>
> Description
> -------
>
> Add new gemfire-common project containing code for Experimental annotation under main and a UnitTest under test.
>
> Add gemfire-common to gemfire-assembly for publishing.
>
> Add dependency on gemfire-common to gemfire-core, gemfire-rebalancer, and gemfire-web.
>
>
> Diffs
> -----
>
> gemfire-assembly/build.gradle b351729
> gemfire-common/build.gradle PRE-CREATION
> gemfire-common/src/main/java/com/gemstone/gemfire/annotations/Experimental.java PRE-CREATION
> gemfire-common/src/test/java/com/gemstone/gemfire/annotations/ExperimentalJUnitTest.java PRE-CREATION
> gemfire-common/src/test/java/com/gemstone/gemfire/annotations/experimentalpackage/ClassInExperimentalPackage.java PRE-CREATION
> gemfire-common/src/test/java/com/gemstone/gemfire/annotations/experimentalpackage/package-info.java PRE-CREATION
> gemfire-common/src/test/java/com/gemstone/gemfire/experimental/nonexperimentalpackage/ClassInNonExperimentalPackage.java PRE-CREATION
> gemfire-common/src/test/java/com/gemstone/gemfire/experimental/nonexperimentalpackage/package-info.java PRE-CREATION
> gemfire-core/build.gradle 1c17474
> gemfire-rebalancer/build.gradle d87dd58
> gemfire-web/build.gradle f0de25a
> settings.gradle 4b2da7b
>
> Diff: https://reviews.apache.org/r/39879/diff/
>
>
> Testing
> -------
>
> clean build and unit testing of the new annotation
>
>
> Thanks,
>
> Kirk Lund
>
>
Re: Review Request 39879: Add gemfire-common and @Experimental
annotation
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39879/#review104808
-----------------------------------------------------------
gemfire-web/build.gradle (line 15)
<https://reviews.apache.org/r/39879/#comment163050>
I think this change was added to the diff by latest down-merge of develop HEAD to my branch. Let me know which is correct (testRuntime or provided).
- Kirk Lund
On Nov. 2, 2015, 9:57 p.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39879/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 9:57 p.m.)
>
>
> Review request for geode, Anthony Baker, William Markito, and Mark Bretl.
>
>
> Bugs: GEODE-328
> https://issues.apache.org/jira/browse/GEODE-328
>
>
> Repository: geode
>
>
> Description
> -------
>
> Add new gemfire-common project containing code for Experimental annotation under main and a UnitTest under test.
>
> Add gemfire-common to gemfire-assembly for publishing.
>
> Add dependency on gemfire-common to gemfire-core, gemfire-rebalancer, and gemfire-web.
>
>
> Diffs
> -----
>
> gemfire-assembly/build.gradle b351729
> gemfire-common/build.gradle PRE-CREATION
> gemfire-common/src/main/java/com/gemstone/gemfire/annotations/Experimental.java PRE-CREATION
> gemfire-common/src/test/java/com/gemstone/gemfire/annotations/ExperimentalJUnitTest.java PRE-CREATION
> gemfire-common/src/test/java/com/gemstone/gemfire/annotations/experimentalpackage/ClassInExperimentalPackage.java PRE-CREATION
> gemfire-common/src/test/java/com/gemstone/gemfire/annotations/experimentalpackage/package-info.java PRE-CREATION
> gemfire-common/src/test/java/com/gemstone/gemfire/experimental/nonexperimentalpackage/ClassInNonExperimentalPackage.java PRE-CREATION
> gemfire-common/src/test/java/com/gemstone/gemfire/experimental/nonexperimentalpackage/package-info.java PRE-CREATION
> gemfire-core/build.gradle 1c17474
> gemfire-rebalancer/build.gradle d87dd58
> gemfire-web/build.gradle f0de25a
> settings.gradle 4b2da7b
>
> Diff: https://reviews.apache.org/r/39879/diff/
>
>
> Testing
> -------
>
> clean build and unit testing of the new annotation
>
>
> Thanks,
>
> Kirk Lund
>
>
Re: Review Request 39879: Add gemfire-common and @Experimental annotation
Posted by Kirk Lund <ki...@gmail.com>.
Re: gemfire-test -- most of our test utility code is for DistributedTests
and uses GemFire classes (API and internal) so we cannot move these classes
to gemfire-test (it would be a circular dependency) until after we move API
classes to gemfire-api.
-Kirk
On Tue, Nov 3, 2015 at 7:38 AM, Anthony Baker <ab...@apache.org> wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39879/
>
> On November 3rd, 2015, 4:22 a.m. UTC, *Dan Smith* wrote:
>
>
> - Should this be consolodated with gemfire-junit?
> - Or maybe we should have a gemfire-api project and move the rest of the public API there as well?
>
> FWIW, I asked the same questions initially and got denied :-)
>
> We should (eventually) rename gemfire-junit to gemfire-test and put our test utilities and supporting test code in there.
>
> I think for now we continue to use the *.internal.* package naming to differentiate between API and implementation. That means gemfire-common can contain both public classes and internal classes that are useful across all other modules. IOW, gemfire-common is at the root of the module dependency tree.
>
> When we refactor to break dependencies such that we *can* separate out an API module (both for client and server) we definitely should.
>
> IMO
>
>
> - Anthony
>
> On November 2nd, 2015, 9:57 p.m. UTC, Kirk Lund wrote:
> Review request for geode, Anthony Baker, William Markito, and Mark Bretl.
> By Kirk Lund.
>
> *Updated Nov. 2, 2015, 9:57 p.m.*
> *Bugs: * GEODE-328 <https://issues.apache.org/jira/browse/GEODE-328>
> *Repository: * geode
> Description
>
> Add new gemfire-common project containing code for Experimental annotation under main and a UnitTest under test.
>
> Add gemfire-common to gemfire-assembly for publishing.
>
> Add dependency on gemfire-common to gemfire-core, gemfire-rebalancer, and gemfire-web.
>
> Testing
>
> clean build and unit testing of the new annotation
>
> Diffs
>
> - gemfire-assembly/build.gradle (b351729)
> - gemfire-common/build.gradle (PRE-CREATION)
> - gemfire-common/src/main/java/com/gemstone/gemfire/annotations/Experimental.java
> (PRE-CREATION)
> - gemfire-common/src/test/java/com/gemstone/gemfire/annotations/ExperimentalJUnitTest.java
> (PRE-CREATION)
> - gemfire-common/src/test/java/com/gemstone/gemfire/annotations/experimentalpackage/ClassInExperimentalPackage.java
> (PRE-CREATION)
> - gemfire-common/src/test/java/com/gemstone/gemfire/annotations/experimentalpackage/package-info.java
> (PRE-CREATION)
> - gemfire-common/src/test/java/com/gemstone/gemfire/experimental/nonexperimentalpackage/ClassInNonExperimentalPackage.java
> (PRE-CREATION)
> - gemfire-common/src/test/java/com/gemstone/gemfire/experimental/nonexperimentalpackage/package-info.java
> (PRE-CREATION)
> - gemfire-core/build.gradle (1c17474)
> - gemfire-rebalancer/build.gradle (d87dd58)
> - gemfire-web/build.gradle (f0de25a)
> - settings.gradle (4b2da7b)
>
> View Diff <https://reviews.apache.org/r/39879/diff/>
>
Re: Review Request 39879: Add gemfire-common and @Experimental
annotation
Posted by Anthony Baker <ab...@apache.org>.
> On Nov. 3, 2015, 4:22 a.m., Dan Smith wrote:
> > - Should this be consolodated with gemfire-junit?
> > - Or maybe we should have a gemfire-api project and move the rest of the public API there as well?
FWIW, I asked the same questions initially and got denied :-)
We should (eventually) rename gemfire-junit to gemfire-test and put our test utilities and supporting test code in there.
I think for now we continue to use the *.internal.* package naming to differentiate between API and implementation. That means gemfire-common can contain both public classes and internal classes that are useful across all other modules. IOW, gemfire-common is at the root of the module dependency tree.
When we refactor to break dependencies such that we *can* separate out an API module (both for client and server) we definitely should.
IMO
- Anthony
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39879/#review104869
-----------------------------------------------------------
On Nov. 2, 2015, 9:57 p.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39879/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 9:57 p.m.)
>
>
> Review request for geode, Anthony Baker, William Markito, and Mark Bretl.
>
>
> Bugs: GEODE-328
> https://issues.apache.org/jira/browse/GEODE-328
>
>
> Repository: geode
>
>
> Description
> -------
>
> Add new gemfire-common project containing code for Experimental annotation under main and a UnitTest under test.
>
> Add gemfire-common to gemfire-assembly for publishing.
>
> Add dependency on gemfire-common to gemfire-core, gemfire-rebalancer, and gemfire-web.
>
>
> Diffs
> -----
>
> gemfire-assembly/build.gradle b351729
> gemfire-common/build.gradle PRE-CREATION
> gemfire-common/src/main/java/com/gemstone/gemfire/annotations/Experimental.java PRE-CREATION
> gemfire-common/src/test/java/com/gemstone/gemfire/annotations/ExperimentalJUnitTest.java PRE-CREATION
> gemfire-common/src/test/java/com/gemstone/gemfire/annotations/experimentalpackage/ClassInExperimentalPackage.java PRE-CREATION
> gemfire-common/src/test/java/com/gemstone/gemfire/annotations/experimentalpackage/package-info.java PRE-CREATION
> gemfire-common/src/test/java/com/gemstone/gemfire/experimental/nonexperimentalpackage/ClassInNonExperimentalPackage.java PRE-CREATION
> gemfire-common/src/test/java/com/gemstone/gemfire/experimental/nonexperimentalpackage/package-info.java PRE-CREATION
> gemfire-core/build.gradle 1c17474
> gemfire-rebalancer/build.gradle d87dd58
> gemfire-web/build.gradle f0de25a
> settings.gradle 4b2da7b
>
> Diff: https://reviews.apache.org/r/39879/diff/
>
>
> Testing
> -------
>
> clean build and unit testing of the new annotation
>
>
> Thanks,
>
> Kirk Lund
>
>
Re: Review Request 39879: Add gemfire-common and @Experimental
annotation
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39879/#review104869
-----------------------------------------------------------
Ship it!
- Should this be consolodated with gemfire-junit?
- Or maybe we should have a gemfire-api project and move the rest of the public API there as well?
- Dan Smith
On Nov. 2, 2015, 9:57 p.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39879/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 9:57 p.m.)
>
>
> Review request for geode, Anthony Baker, William Markito, and Mark Bretl.
>
>
> Bugs: GEODE-328
> https://issues.apache.org/jira/browse/GEODE-328
>
>
> Repository: geode
>
>
> Description
> -------
>
> Add new gemfire-common project containing code for Experimental annotation under main and a UnitTest under test.
>
> Add gemfire-common to gemfire-assembly for publishing.
>
> Add dependency on gemfire-common to gemfire-core, gemfire-rebalancer, and gemfire-web.
>
>
> Diffs
> -----
>
> gemfire-assembly/build.gradle b351729
> gemfire-common/build.gradle PRE-CREATION
> gemfire-common/src/main/java/com/gemstone/gemfire/annotations/Experimental.java PRE-CREATION
> gemfire-common/src/test/java/com/gemstone/gemfire/annotations/ExperimentalJUnitTest.java PRE-CREATION
> gemfire-common/src/test/java/com/gemstone/gemfire/annotations/experimentalpackage/ClassInExperimentalPackage.java PRE-CREATION
> gemfire-common/src/test/java/com/gemstone/gemfire/annotations/experimentalpackage/package-info.java PRE-CREATION
> gemfire-common/src/test/java/com/gemstone/gemfire/experimental/nonexperimentalpackage/ClassInNonExperimentalPackage.java PRE-CREATION
> gemfire-common/src/test/java/com/gemstone/gemfire/experimental/nonexperimentalpackage/package-info.java PRE-CREATION
> gemfire-core/build.gradle 1c17474
> gemfire-rebalancer/build.gradle d87dd58
> gemfire-web/build.gradle f0de25a
> settings.gradle 4b2da7b
>
> Diff: https://reviews.apache.org/r/39879/diff/
>
>
> Testing
> -------
>
> clean build and unit testing of the new annotation
>
>
> Thanks,
>
> Kirk Lund
>
>