[jira] [Commented] (SLING-7299) slingstart-maven-plugin: Do not always attach artifact in goal "package"

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-7299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284844#comment-16284844 ] 

ASF GitHub Bot commented on SLING-7299:
---------------------------------------

kwin opened a new pull request #1: SLING-7299 do not always attach built artifact
URL: https://github.com/apache/sling-slingstart-maven-plugin/pull/1
 
 
   introduce new parameter "attachArtifact" (default=true) to allow to
   prevent attaching artifacts (only in case packaging != slingstart)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> slingstart-maven-plugin: Do not always attach artifact in goal "package"
> ------------------------------------------------------------------------
>
>                 Key: SLING-7299
>                 URL: https://issues.apache.org/jira/browse/SLING-7299
>             Project: Sling
>          Issue Type: Improvement
>    Affects Versions: Slingstart Maven Plugin 1.7.10
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>             Fix For: Slingstart Maven Plugin 1.7.12
>
>
> In case the packaging is not {{slingstart}} that generated artifact is still attached to the project (and therefore potentially also deployed via mvn deploy) (https://github.com/apache/sling-slingstart-maven-plugin/blob/master/src/main/java/org/apache/sling/maven/slingstart/PackageMojo.java#L95). This is not desired in case the model is only used for running a local IT against the server being generated from the model. Therefore there should be an additional parameter which prevents the artifact from being attached.
> Since the attached artifact is currently also used from goal {{start}} (https://github.com/apache/sling-slingstart-maven-plugin/blob/master/src/main/java/org/apache/sling/maven/slingstart/run/StartMojo.java#L396) there must be another way introduced to detect slingstart artifacts which have been generated through the same maven build by a previous step.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)