You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/18 13:48:35 UTC
[GitHub] [shardingsphere] JasonKing168 opened a new pull request #5229: Fix
#5200 to use new Inline algorithm for configurations of annotated tests
JasonKing168 opened a new pull request #5229: Fix #5200 to use new Inline algorithm for configurations of annotated tests
URL: https://github.com/apache/shardingsphere/pull/5229
Fixes #5200.
Changes proposed in this pull request:
-
-
-
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [shardingsphere] tristaZero commented on issue #5229: Fix #5200 to
use new Inline algorithm for configurations of annotated tests
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #5229: Fix #5200 to use new Inline algorithm for configurations of annotated tests
URL: https://github.com/apache/shardingsphere/pull/5229#issuecomment-615996387
Hi @JasonKing168 It is glad to see you again. :) BTW, could you give a look at my comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [shardingsphere] tristaZero merged pull request #5229: Fix #5200 to
use new Inline algorithm for configurations of annotated tests
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #5229: Fix #5200 to use new Inline algorithm for configurations of annotated tests
URL: https://github.com/apache/shardingsphere/pull/5229
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [shardingsphere] tristaZero commented on a change in pull request
#5229: Fix #5200 to use new Inline algorithm for configurations of
annotated tests
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #5229: Fix #5200 to use new Inline algorithm for configurations of annotated tests
URL: https://github.com/apache/shardingsphere/pull/5229#discussion_r410782045
##########
File path: sharding-distribution/sharding-proxy-distribution/src/main/resources/conf/config-sharding.yaml
##########
@@ -80,51 +89,60 @@
#
######################################################################################################
-#schemaName: sharding_db
-#
-#dataSources:
-# ds_0:
-# url: jdbc:mysql://127.0.0.1:3306/demo_ds_0?serverTimezone=UTC&useSSL=false
-# username: root
-# password:
-# connectionTimeoutMilliseconds: 30000
-# idleTimeoutMilliseconds: 60000
-# maxLifetimeMilliseconds: 1800000
-# maxPoolSize: 50
-# ds_1:
-# url: jdbc:mysql://127.0.0.1:3306/demo_ds_1?serverTimezone=UTC&useSSL=false
-# username: root
-# password:
-# connectionTimeoutMilliseconds: 30000
-# idleTimeoutMilliseconds: 60000
-# maxLifetimeMilliseconds: 1800000
-# maxPoolSize: 50
-#
-#shardingRule:
-# tables:
-# t_order:
-# actualDataNodes: ds_${0..1}.t_order_${0..1}
-# tableStrategy:
-# inline:
-# shardingColumn: order_id
-# algorithmExpression: t_order_${order_id % 2}
-# keyGenerator:
-# type: SNOWFLAKE
-# column: order_id
-# t_order_item:
-# actualDataNodes: ds_${0..1}.t_order_item_${0..1}
-# tableStrategy:
-# inline:
-# shardingColumn: order_id
-# algorithmExpression: t_order_item_${order_id % 2}
-# keyGenerator:
-# type: SNOWFLAKE
-# column: order_item_id
-# bindingTables:
-# - t_order,t_order_item
-# defaultDatabaseStrategy:
-# inline:
-# shardingColumn: user_id
-# algorithmExpression: ds_${user_id % 2}
-# defaultTableStrategy:
-# none:
+schemaName: sharding_db
Review comment:
Hi, Please comment out that configuration to retain the initial status.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [shardingsphere] tristaZero commented on issue #5229: Fix #5200 to
use new Inline algorithm for configurations of annotated tests
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #5229: Fix #5200 to use new Inline algorithm for configurations of annotated tests
URL: https://github.com/apache/shardingsphere/pull/5229#issuecomment-616144459
@JasonKing168
BTW, as you are the proper one to tackle with #5234, which is similar to #5200 , I'd like to listen to your voice whether you want to take charge of it? Please be free to give your opinion.
Best,
Trista
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [shardingsphere] tristaZero commented on issue #5229: Fix #5200 to
use new Inline algorithm for configurations of annotated tests
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #5229: Fix #5200 to use new Inline algorithm for configurations of annotated tests
URL: https://github.com/apache/shardingsphere/pull/5229#issuecomment-616135984
Hi since CI test got something wrong, I merged your PR and tested Sharding Proxy
with those new APIs. The result showed it worked well with your changes!
Thanks a lot, @JasonKing168 :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [shardingsphere] JasonKing168 commented on issue #5229: Fix #5200
to use new Inline algorithm for configurations of annotated tests
Posted by GitBox <gi...@apache.org>.
JasonKing168 commented on issue #5229: Fix #5200 to use new Inline algorithm for configurations of annotated tests
URL: https://github.com/apache/shardingsphere/pull/5229#issuecomment-616107138
> Hi @JasonKing168 It is glad to see you again. :) BTW, could you give a look at my comment?
Sure. Review again, please, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [shardingsphere] tristaZero commented on a change in pull request
#5229: Fix #5200 to use new Inline algorithm for configurations of
annotated tests
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #5229: Fix #5200 to use new Inline algorithm for configurations of annotated tests
URL: https://github.com/apache/shardingsphere/pull/5229#discussion_r410782012
##########
File path: sharding-proxy/sharding-proxy-bootstrap/src/main/resources/conf/config-sharding.yaml
##########
@@ -81,51 +90,60 @@
#
######################################################################################################
-#schemaName: sharding_db
-#
-#dataSources:
-# ds_0:
-# url: jdbc:mysql://127.0.0.1:3306/demo_ds_0?serverTimezone=UTC&useSSL=false
-# username: root
-# password:
-# connectionTimeoutMilliseconds: 30000
-# idleTimeoutMilliseconds: 60000
-# maxLifetimeMilliseconds: 1800000
-# maxPoolSize: 50
-# ds_1:
-# url: jdbc:mysql://127.0.0.1:3306/demo_ds_1?serverTimezone=UTC&useSSL=false
-# username: root
-# password:
-# connectionTimeoutMilliseconds: 30000
-# idleTimeoutMilliseconds: 60000
-# maxLifetimeMilliseconds: 1800000
-# maxPoolSize: 50
-#
-#shardingRule:
-# tables:
-# t_order:
-# actualDataNodes: ds_${0..1}.t_order_${0..1}
-# tableStrategy:
-# inline:
-# shardingColumn: order_id
-# algorithmExpression: t_order_${order_id % 2}
-# keyGenerator:
-# type: SNOWFLAKE
-# column: order_id
-# t_order_item:
-# actualDataNodes: ds_${0..1}.t_order_item_${0..1}
-# tableStrategy:
-# inline:
-# shardingColumn: order_id
-# algorithmExpression: t_order_item_${order_id % 2}
-# keyGenerator:
-# type: SNOWFLAKE
-# column: order_item_id
-# bindingTables:
-# - t_order,t_order_item
-# defaultDatabaseStrategy:
-# inline:
-# shardingColumn: user_id
-# algorithmExpression: ds_${user_id % 2}
-# defaultTableStrategy:
-# none:
+schemaName: sharding_db
Review comment:
Hi, Please comment out that configuration to retain the initial status.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services