You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by andytaylor <gi...@git.apache.org> on 2016/09/28 11:57:13 UTC

[GitHub] activemq-artemis pull request #810: ARTEMIS-758 - List/Object message sent b...

GitHub user andytaylor opened a pull request:

    https://github.com/apache/activemq-artemis/pull/810

    ARTEMIS-758 - List/Object message sent by OpenWire JMS client can't b\u2026

    \u2026e consumed with other clients
    
    https://issues.apache.org/jira/browse/ARTEMIS-758

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andytaylor/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/810.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #810
    
----
commit b51de626b2fdbcb64ae71fd7eb2531402635feac
Author: Andy Taylor <an...@gmail.com>
Date:   2016-09-28T11:29:25Z

    ARTEMIS-758 - List/Object message sent by OpenWire JMS client can't be consumed with other clients
    
    https://issues.apache.org/jira/browse/ARTEMIS-758

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #810: ARTEMIS-758 - List/Object message sent by OpenW...

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/810
  
    If not fixable, I would add release notes to export / import data between the releases if you are storing ObjectMessages that were sent by the affected protocols.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #810: ARTEMIS-758 - List/Object message sent by OpenW...

Posted by mtaylor <gi...@git.apache.org>.

Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/810
  
    The issue aiui is that the CORE object message encoding adds some additional data to the serialized byte stream received from the client, it prepends the byte with the length of the binary, I presume this was used in the past when reading the binary back from the Journal.   The problem with just dumping the byte stream as we were doing previously, is that there's a different encoding for CORE vs OpenWire.  This small changes ensures that both encodings are the same.  
    
    Another way to approach this would have been to add some extra meta-data to the message describing it's content as @tabish121 mentioned with the "'application/x-java-serialized-object" type or something similar.  I think we can do that as part of the larger task of removing the translations.  Right now though, this small change fixes the cross protocol issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #810: ARTEMIS-758 - List/Object message sent by OpenW...

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/810
  
    
    @andytaylor this actually broke a TestConversion test.
    
    Wouldn't this break compatiblity if something is already stored on the journal?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #810: ARTEMIS-758 - List/Object message sent by OpenW...

Posted by andytaylor <gi...@git.apache.org>.

Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/810
  
    this is for proton-j so it can be wrapped in an amqpvalue before delivery


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #810: ARTEMIS-758 - List/Object message sent by OpenW...

Posted by tabish121 <gi...@git.apache.org>.

Github user tabish121 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/810
  
    A JMS Message sent for OpenWire / Core or wherever should contain a Binary message body and that value can just be placed directly into a Data value as the original Binary without need to decode it.  As an extra nicety you can throw in the 'application/x-java-serialized-object' content type value and then for things like Qpid JMS that understand that you'd get an ObjectMessage out on the client's consumer and treat the same as any other JMS client getting an ObjectMessage by calling getObject and hoping you had the right classes on the Classpath


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #810: ARTEMIS-758 - List/Object message sent by OpenW...

Posted by andytaylor <gi...@git.apache.org>.

Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/810
  
    @tabish121 Artemis is doing pretty much the same as ActiveMQ was until you're refactoring around proton-j. We should probably try to do the same but this should suffice until then


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #810: ARTEMIS-758 - List/Object message sent by OpenW...

Posted by andytaylor <gi...@git.apache.org>.

Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/810
  
    Ive fixed the test.
    
    yes it would, Im not sure how we can address this but it needs fixing for cross protocol to work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #810: ARTEMIS-758 - List/Object message sent by OpenW...

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/810
  
    I will merge this now as I will change checkstyle


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #810: ARTEMIS-758 - List/Object message sent by OpenW...

Posted by tabish121 <gi...@git.apache.org>.

Github user tabish121 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/810
  
    Why are ObjectMessage being deserialized on the server when passing from OpenWire to AMQP would be my first question.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---