You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/22 09:19:39 UTC

[GitHub] [arrow-datafusion] Ted-Jiang commented on a diff in pull request #4283: Reduce Expr copies in `ParquetExec`

Ted-Jiang commented on code in PR #4283:
URL: https://github.com/apache/arrow-datafusion/pull/4283#discussion_r1029067828


##########
datafusion/core/src/physical_plan/file_format/parquet.rs:
##########
@@ -76,9 +76,9 @@ pub struct ParquetExec {
     /// Execution metrics
     metrics: ExecutionPlanMetricsSet,
     /// Optional predicate for row filtering during parquet scan
-    predicate: Option<Expr>,
+    predicate: Option<Arc<Expr>>,

Review Comment:
   >these predicates get copied once for each parquet file
   
   Just question: I can not find the code clone for each file🤔, but this improvement is reasonable👍. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org