You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2014/08/10 18:37:55 UTC
[Issue 125400] New: Chinese numbering in docx fallback to Arabic
numerals
https://issues.apache.org/ooo/show_bug.cgi?id=125400
Issue ID: 125400
Issue Type: DEFECT
Summary: Chinese numbering in docx fallback to Arabic numerals
Product: Writer
Version: 4.2.0-dev
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: open-import
Assignee: issues@openoffice.apache.org
Reporter: marklh9@gmail.com
Created attachment 83808
--> https://issues.apache.org/ooo/attachment.cgi?id=83808&action=edit
Original numbering in a docx file in MSO
Chinese numbering in docx fallback to Arabic numerals.
This issue is specific to the docx files created by traditional Chinese version
of MSO that were used in taiwan. More specifically, taiwaneseCountingThousand
of w:numfmt attribute in ooxml is ignored.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] CJK numbering ordered list fallback to Arabic
numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
--- Comment #21 from Steve Yin <st...@gmail.com> ---
(In reply to Mark Hung from comment #20)
> hi Steve,
>
> Thank you. After months passed, I've done submitting similar fix to
> LibreOffice
>
> https://gerrit.libreoffice.org/#/c/12252/
>
> I'd like to take some time to update patch I submitted here, especially for
> coding style and differentiating simplified Chinese and traditional Chinese.
> Would you suggest that I just obsolte patch here, or wait for you to merge
> the code first?
Hi Mark,
I found that you and other contributors made some improvements on this patch.
So my suggestion is that you can obsolete the old patch and update a new patch.
Then I will deliver your latest patch in the trunk. Thanks.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] Chinese numbering fallback to Arabic numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
--- Comment #15 from Steve Yin <st...@gmail.com> ---
@Oliver: any comments?
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] CJK numbering ordered list fallback to Arabic
numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
--- Comment #23 from Steve Yin <st...@gmail.com> ---
Hi Mark,
Thanks. I will take care of it. :)
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] Chinese numbering fallback to Arabic numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
Mark Hung <ma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Chinese numbering in docx |Chinese numbering fallback
|fallback to Arabic numerals |to Arabic numerals
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] CJK numbering ordered list fallback to Arabic
numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
--- Comment #19 from Steve Yin <st...@gmail.com> ---
(In reply to Mark Hung from comment #18)
> Hi Developers,
>
> What's happening?
> Is there anyone working on verifying or merging the patch?
> Do I need to improve anything or provide any information
> in order to get it merged?
Hi Mark,
Sorry for the late reply. Something changes in the community... I will check
them in. Thank you for your contribution again!
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] Chinese numbering in docx fallback to Arabic numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
Mark Hung <ma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |marklh9@gmail.com
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] Chinese numbering fallback to Arabic numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
Andrea Pescetti <pe...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pescetti@apache.org
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] Chinese numbering fallback to Arabic numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
Mark Hung <ma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #83841|0 |1
is obsolete| |
--- Comment #9 from Mark Hung <ma...@gmail.com> ---
Created attachment 83890
--> https://issues.apache.org/ooo/attachment.cgi?id=83890&action=edit
Patch for Chinese(ZH-TW) numbering issues
* RTF import
* RTF export
* doc import and export
* docx import
Update supports to RTF export. Also export SVX_NUM_NUMBER_LOWER_ZH based on
application language setting. Map to 39 if LANGUAGE_CHINESE_SIMPLIFIED and 35
otherwise.
Note that there are several Chinese numbering type in MSO that has minor
difference, and is not implemented in AOO. For example, a circle that represent
zero were used in some cases. They are inevitably all mapped to
SVX_NUM_NUMBER_LOWER_ZH and are not able to mapped back again. So I'd advice to
accept current implementation unless any side effects are found.
If it is possible to find Japanese testers, we can improve it further. They are
all the same.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] Chinese numbering fallback to Arabic numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
--- Comment #8 from Steve Yin <st...@gmail.com> ---
There are two cases which cannot identify ZH-TW and ZH-CN. It seems that a new
definition is needed.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] Chinese numbering in docx fallback to Arabic numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
--- Comment #3 from Mark Hung <ma...@gmail.com> ---
Created attachment 83811
--> https://issues.apache.org/ooo/attachment.cgi?id=83811&action=edit
Patch for fixing the issue.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] CJK numbering ordered list fallback to Arabic
numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
--- Comment #17 from Mark Hung <ma...@gmail.com> ---
Created attachment 83968
--> https://issues.apache.org/ooo/attachment.cgi?id=83968&action=edit
Patch for CJK numbering issues.
This patch includes Japanese & Korean numbering.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] Chinese numbering fallback to Arabic numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |orw@apache.org
--- Comment #11 from Oliver-Rainer Wittmann <or...@apache.org> ---
I will also have a look at this issue.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] CJK numbering ordered list fallback to Arabic
numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
--- Comment #20 from Mark Hung <ma...@gmail.com> ---
hi Steve,
Thank you. After months passed, I've done submitting similar fix to
LibreOffice
https://gerrit.libreoffice.org/#/c/12252/
I'd like to take some time to update patch I submitted here, especially for
coding style and differentiating simplified Chinese and traditional Chinese.
Would you suggest that I just obsolte patch here, or wait for you to merge the
code first?
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] CJK numbering ordered list fallback to Arabic
numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
Mark Hung <ma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Chinese numbering fallback |CJK numbering ordered list
|to Arabic numerals |fallback to Arabic numerals
--- Comment #16 from Mark Hung <ma...@gmail.com> ---
See also https://issues.apache.org/ooo/show_bug.cgi?id=69855
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] Chinese numbering fallback to Arabic numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
--- Comment #12 from Mark Hung <ma...@gmail.com> ---
Created attachment 83894
--> https://issues.apache.org/ooo/attachment.cgi?id=83894&action=edit
Explain for the test case.
Note that improvement for docx import is only for LOWER_NUMBER_ZH and
FULL_WIDTH_NUMBER.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] Chinese numbering in docx fallback to Arabic numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
Mark Hung <ma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #83840|0 |1
is obsolete| |
--- Comment #5 from Mark Hung <ma...@gmail.com> ---
Created attachment 83841
--> https://issues.apache.org/ooo/attachment.cgi?id=83841&action=edit
Patch for Chinese(ZH-TW) numbering issues
Check 'patch' field. Following Chinese(ZH-TW) issues were fixed:
* RTF import
* doc import and export
* docx import
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] CJK numbering ordered list fallback to Arabic
numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
Mark Hung <ma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #83890|0 |1
is obsolete| |
Attachment #83968|0 |1
is obsolete| |
Attachment #84246| |review?
Flags| |
--- Comment #22 from Mark Hung <ma...@gmail.com> ---
Created attachment 84246
--> https://issues.apache.org/ooo/attachment.cgi?id=84246&action=edit
Patch for fixing CJK numbered list.
Update patch. This patch differs from previous patches in (a)code clean up
(b)Export NUMBER_LOWER_ZH as differnt values of Simplified Chinese or
Traditional Chinese based on language setting.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] Chinese numbering fallback to Arabic numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
--- Comment #10 from Steve Yin <st...@gmail.com> ---
(In reply to Mark Hung from comment #9)
> Created attachment 83890 [details]
> Patch for Chinese(ZH-TW) numbering issues
>
>
> * RTF import
> * RTF export
> * doc import and export
> * docx import
>
> Update supports to RTF export. Also export SVX_NUM_NUMBER_LOWER_ZH based on
> application language setting. Map to 39 if LANGUAGE_CHINESE_SIMPLIFIED and
> 35 otherwise.
>
> Note that there are several Chinese numbering type in MSO that has minor
> difference, and is not implemented in AOO. For example, a circle that
> represent zero were used in some cases. They are inevitably all mapped to
> SVX_NUM_NUMBER_LOWER_ZH and are not able to mapped back again. So I'd advice
> to accept current implementation unless any side effects are found.
>
> If it is possible to find Japanese testers, we can improve it further. They
> are all the same.
Thanks for fixing RTF export.
I found the patch did not work for docx import.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] Chinese numbering in docx fallback to Arabic numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
--- Comment #1 from Mark Hung <ma...@gmail.com> ---
Created attachment 83809
--> https://issues.apache.org/ooo/attachment.cgi?id=83809&action=edit
Chinese numbering fallback to Arabic numerals in AOO
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] Chinese numbering in docx fallback to Arabic numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
Mark Hung <ma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Issue Type|DEFECT |PATCH
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] Chinese numbering in docx fallback to Arabic numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
Mark Hung <ma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #83811|0 |1
is obsolete| |
--- Comment #4 from Mark Hung <ma...@gmail.com> ---
Created attachment 83840
--> https://issues.apache.org/ooo/attachment.cgi?id=83840&action=edit
Patch to filters for Chinese(ZH-TW) numbering issues
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] Chinese numbering fallback to Arabic numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
Mark Hung <ma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #83808|0 |1
is obsolete| |
Attachment #83809|0 |1
is obsolete| |
Attachment #83810|0 |1
is obsolete| |
--- Comment #14 from Mark Hung <ma...@gmail.com> ---
Created attachment 83901
--> https://issues.apache.org/ooo/attachment.cgi?id=83901&action=edit
All test cases(zipped)
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] CJK numbering ordered list fallback to Arabic
numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
--- Comment #18 from Mark Hung <ma...@gmail.com> ---
Hi Developers,
What's happening?
Is there anyone working on verifying or merging the patch?
Do I need to improve anything or provide any information
in order to get it merged?
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] CJK numbering ordered list fallback to Arabic
numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
--- Comment #25 from SVN Robot <sv...@dev.null.org> ---
"steve_y" committed SVN revision 1642310 into trunk:
Issue 125400 - CJK numbering ordered list fallback to Arabic numerals
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] Chinese numbering fallback to Arabic numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
Mark Hung <ma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #83894|0 |1
is obsolete| |
--- Comment #13 from Mark Hung <ma...@gmail.com> ---
Created attachment 83900
--> https://issues.apache.org/ooo/attachment.cgi?id=83900&action=edit
Complete test cases explain
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] Chinese numbering in docx fallback to Arabic numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
--- Comment #2 from Mark Hung <ma...@gmail.com> ---
Created attachment 83810
--> https://issues.apache.org/ooo/attachment.cgi?id=83810&action=edit
Test case.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
review requested: [Issue 125400] CJK numbering ordered list fallback
to Arabic numerals : [Attachment 84246] Patch for fixing CJK numbered list.
Posted by bu...@apache.org.
Mark Hung <ma...@gmail.com> has asked for review:
Issue 125400: CJK numbering ordered list fallback to Arabic numerals
https://issues.apache.org/ooo/show_bug.cgi?id=125400
Attachment 84246: Patch for fixing CJK numbered list.
https://issues.apache.org/ooo/attachment.cgi?id=84246&action=edit
[Issue 125400] Chinese numbering fallback to Arabic numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
Steve Yin <st...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |CONFIRMED
CC| |steve.yin.aoo@gmail.com
Ever confirmed|0 |1
--- Comment #6 from Steve Yin <st...@gmail.com> ---
(In reply to Mark Hung from comment #5)
> Created attachment 83841 [details]
> Patch for Chinese(ZH-TW) numbering issues
>
> Check 'patch' field. Following Chinese(ZH-TW) issues were fixed:
>
> * RTF import
> * doc import and export
> * docx import
Hi Mark,
I applied your patch and found that the issue was not fixed. Can you check it?
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] CJK numbering ordered list fallback to Arabic
numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
Steve Yin <st...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #24 from Steve Yin <st...@gmail.com> ---
The patch is OK. UT passed.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125400] Chinese numbering fallback to Arabic numerals
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125400
--- Comment #7 from Steve Yin <st...@gmail.com> ---
(In reply to Steve Yin from comment #6)
> (In reply to Mark Hung from comment #5)
> > Created attachment 83841 [details]
> > Patch for Chinese(ZH-TW) numbering issues
> >
> > Check 'patch' field. Following Chinese(ZH-TW) issues were fixed:
> >
> > * RTF import
> > * doc import and export
> > * docx import
>
> Hi Mark,
>
> I applied your patch and found that the issue was not fixed. Can you check
> it?
Sorry, I mixed it up with i125495.
This patch works.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.