You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by xwq <gi...@git.apache.org> on 2015/11/26 13:16:35 UTC
[GitHub] incubator-trafodion pull request: [TRAFODION-1558]Tableau returns ...
GitHub user xwq opened a pull request:
https://github.com/apache/incubator-trafodion/pull/192
[TRAFODION-1558]Tableau returns to tables or data
[TRAFODION-1558]Used driver connection with TCP:<ip>/<port>. Connection
succeeded but no schemas or tables are listed. It's was casued by the
driver use long (4 bytes) to store the points (8 bytes) which caused data
loss. The fix is use LONG_PTR insteaded.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xwq/incubator-trafodion master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/192.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #192
----
commit a4480b31973850d71bf7b84dfcd3453e390a688c
Author: Weiqing Xu <we...@esgyn.cn>
Date: 2015-11-26T08:36:57Z
[TRAFODION-1558]Tableau returns to tables or data
[TRAFODION-1558]Used driver connection with TCP:<ip>/<port>. Connection
succeeded but no schemas or tables are listed. It's was casued by the
driver use long (4 bytes) to store the points (8 bytes) which caused data
loss. The fix is use LONG_PTR insteaded.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1558]Tableau returns ...
Posted by xwq <gi...@git.apache.org>.
Github user xwq commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/192#discussion_r46234065
--- Diff: win-odbc64/odbcclient/drvr35/cstmt.cpp ---
@@ -3389,7 +3389,7 @@ BOOL CStmt::setFetchOutputPerf(long rowsFetched, SQL_DataValue_def*& outputDataV
m_FetchDataValue.numberOfRows = rowsFetched;
if(rowsFetched > 0)
{
- m_FetchDataValue.rowAddress = new unsigned long[rowsFetched];
+ m_FetchDataValue.rowAddress = new LONG_PTR[rowsFetched];
--- End diff --
The issue here is that the long is 4 bytes in Windows x64. windows can ensure the LONG_PTR is 8 bytes in x64 system and 4 bytes in x32 system. I use LONG_PTR because of a lot Windows API use it . There is no VOID_PTR type.
I can use (void *) instead if you insist .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1558]Tableau returns ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/192
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1558]Tableau returns ...
Posted by selvaganesang <gi...@git.apache.org>.
Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/192#discussion_r46152896
--- Diff: win-odbc64/odbcclient/drvr35/cstmt.cpp ---
@@ -3389,7 +3389,7 @@ BOOL CStmt::setFetchOutputPerf(long rowsFetched, SQL_DataValue_def*& outputDataV
m_FetchDataValue.numberOfRows = rowsFetched;
if(rowsFetched > 0)
{
- m_FetchDataValue.rowAddress = new unsigned long[rowsFetched];
+ m_FetchDataValue.rowAddress = new LONG_PTR[rowsFetched];
--- End diff --
Should it be VOID_PTR or (void *) instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1558]Tableau returns ...
Posted by selvaganesang <gi...@git.apache.org>.
Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/192#discussion_r46240887
--- Diff: win-odbc64/odbcclient/drvr35/cstmt.cpp ---
@@ -3389,7 +3389,7 @@ BOOL CStmt::setFetchOutputPerf(long rowsFetched, SQL_DataValue_def*& outputDataV
m_FetchDataValue.numberOfRows = rowsFetched;
if(rowsFetched > 0)
{
- m_FetchDataValue.rowAddress = new unsigned long[rowsFetched];
+ m_FetchDataValue.rowAddress = new LONG_PTR[rowsFetched];
--- End diff --
Thanks for your prompt response. Use of LONG_PTR is justified very well. No need to change it to void *
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---