You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by jp...@apache.org on 2013/12/21 00:16:42 UTC

git commit: proxy.config.remap.use_remap_processor is dead

Updated Branches:
  refs/heads/master 2548cbcf6 -> 2772ae65a


proxy.config.remap.use_remap_processor is dead


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/2772ae65
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/2772ae65
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/2772ae65

Branch: refs/heads/master
Commit: 2772ae65a5a3fb48fa241c6db3495d9a8bdf165f
Parents: 2548cbc
Author: James Peach <jp...@apache.org>
Authored: Tue Dec 17 14:51:45 2013 -0800
Committer: James Peach <jp...@apache.org>
Committed: Fri Dec 20 15:16:18 2013 -0800

----------------------------------------------------------------------
 .../configuration/records.config.en.rst         | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/2772ae65/doc/reference/configuration/records.config.en.rst
----------------------------------------------------------------------
diff --git a/doc/reference/configuration/records.config.en.rst b/doc/reference/configuration/records.config.en.rst
index 6170b46..c92f351 100644
--- a/doc/reference/configuration/records.config.en.rst
+++ b/doc/reference/configuration/records.config.en.rst
@@ -2152,17 +2152,6 @@ Scheduled Update Configuration
    time. This option prevents the scheduled update process from
    overburdening the host.
 
-Remap Plugin Processor
-======================
-
-.. ts:cv:: CONFIG proxy.config.remap.use_remap_processor INT 0
-
-   Enables (``1``) or disables (``0``) the ability to run separate threads for remap plugin processing.
-
-.. ts:cv:: CONFIG proxy.config.remap.num_remap_threads INT 1
-
-   Specifies the number of threads that will be used for remap plugin rocessing.
-
 Plug-in Configuration
 =====================
 
@@ -2170,6 +2159,15 @@ Plug-in Configuration
 
    Specifies the location of Traffic Server plugins.
 
+.. ts:cv:: CONFIG proxy.config.remap.num_remap_threads INT 0
+
+   When this variable is set to ``0``, plugin remap callbacks are
+   executed in line on network threads. If remap processing takes
+   significant time, this can be cause additional request latency.
+   Setting this variable to causes remap processing to take place
+   on a dedicated thread pool, freeing the network threads to service
+   additional requests.
+
 Sockets
 =======
 


Re: git commit: proxy.config.remap.use_remap_processor is dead

Posted by James Peach <jp...@apache.org>.
On Dec 22, 2013, at 4:28 AM, Igor Galić <i....@brainsware.org> wrote:

> 
> 
> ----- Original Message -----
>> Updated Branches:
>>  refs/heads/master 2548cbcf6 -> 2772ae65a
>> 
>> 
>> proxy.config.remap.use_remap_processor is dead
>> 
>> 
>> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/2772ae65
>> Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/2772ae65
>> Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/2772ae65
>> 
>> Branch: refs/heads/master
>> Commit: 2772ae65a5a3fb48fa241c6db3495d9a8bdf165f
>> Parents: 2548cbc
>> Author: James Peach <jp...@apache.org>
>> Authored: Tue Dec 17 14:51:45 2013 -0800
>> Committer: James Peach <jp...@apache.org>
>> Committed: Fri Dec 20 15:16:18 2013 -0800
>> 
>> ----------------------------------------------------------------------
>> .../configuration/records.config.en.rst         | 20 +++++++++-----------
>> 1 file changed, 9 insertions(+), 11 deletions(-)
>> ----------------------------------------------------------------------
>> 
>> 
>> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/2772ae65/doc/reference/configuration/records.config.en.rst
>> ----------------------------------------------------------------------
>> diff --git a/doc/reference/configuration/records.config.en.rst
>> b/doc/reference/configuration/records.config.en.rst
>> index 6170b46..c92f351 100644
>> --- a/doc/reference/configuration/records.config.en.rst
>> +++ b/doc/reference/configuration/records.config.en.rst
>> @@ -2152,17 +2152,6 @@ Scheduled Update Configuration
>>    time. This option prevents the scheduled update process from
>>    overburdening the host.
>> 
>> -Remap Plugin Processor
>> -======================
>> -
>> -.. ts:cv:: CONFIG proxy.config.remap.use_remap_processor INT 0
>> -
>> -   Enables (``1``) or disables (``0``) the ability to run separate threads
>> for remap plugin processing.
>> -
>> -.. ts:cv:: CONFIG proxy.config.remap.num_remap_threads INT 1
>> -
>> -   Specifies the number of threads that will be used for remap plugin
>> rocessing.
>> -
>> Plug-in Configuration
>> =====================
>> 
>> @@ -2170,6 +2159,15 @@ Plug-in Configuration
>> 
>>    Specifies the location of Traffic Server plugins.
>> 
>> +.. ts:cv:: CONFIG proxy.config.remap.num_remap_threads INT 0
>> +
>> +   When this variable is set to ``0``, plugin remap callbacks are
>> +   executed in line on network threads. If remap processing takes
>> +   significant time, this can be cause additional request latency.
>> +   Setting this variable to causes remap processing to take place
>> +   on a dedicated thread pool, freeing the network threads to service
>> +   additional requests.
>> +
> 
> What's the consequence of doing that?

Remapping probably has higher latency. But you would only do this to avoid blocking net thread because you know that remap is going to take a while, so hopefully it's an improvement overall

J

Re: git commit: proxy.config.remap.use_remap_processor is dead

Posted by Igor Galić <i....@brainsware.org>.

----- Original Message -----
> Updated Branches:
>   refs/heads/master 2548cbcf6 -> 2772ae65a
> 
> 
> proxy.config.remap.use_remap_processor is dead
> 
> 
> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
> Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/2772ae65
> Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/2772ae65
> Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/2772ae65
> 
> Branch: refs/heads/master
> Commit: 2772ae65a5a3fb48fa241c6db3495d9a8bdf165f
> Parents: 2548cbc
> Author: James Peach <jp...@apache.org>
> Authored: Tue Dec 17 14:51:45 2013 -0800
> Committer: James Peach <jp...@apache.org>
> Committed: Fri Dec 20 15:16:18 2013 -0800
> 
> ----------------------------------------------------------------------
>  .../configuration/records.config.en.rst         | 20 +++++++++-----------
>  1 file changed, 9 insertions(+), 11 deletions(-)
> ----------------------------------------------------------------------
> 
> 
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/2772ae65/doc/reference/configuration/records.config.en.rst
> ----------------------------------------------------------------------
> diff --git a/doc/reference/configuration/records.config.en.rst
> b/doc/reference/configuration/records.config.en.rst
> index 6170b46..c92f351 100644
> --- a/doc/reference/configuration/records.config.en.rst
> +++ b/doc/reference/configuration/records.config.en.rst
> @@ -2152,17 +2152,6 @@ Scheduled Update Configuration
>     time. This option prevents the scheduled update process from
>     overburdening the host.
>  
> -Remap Plugin Processor
> -======================
> -
> -.. ts:cv:: CONFIG proxy.config.remap.use_remap_processor INT 0
> -
> -   Enables (``1``) or disables (``0``) the ability to run separate threads
> for remap plugin processing.
> -
> -.. ts:cv:: CONFIG proxy.config.remap.num_remap_threads INT 1
> -
> -   Specifies the number of threads that will be used for remap plugin
> rocessing.
> -
>  Plug-in Configuration
>  =====================
>  
> @@ -2170,6 +2159,15 @@ Plug-in Configuration
>  
>     Specifies the location of Traffic Server plugins.
>  
> +.. ts:cv:: CONFIG proxy.config.remap.num_remap_threads INT 0
> +
> +   When this variable is set to ``0``, plugin remap callbacks are
> +   executed in line on network threads. If remap processing takes
> +   significant time, this can be cause additional request latency.
> +   Setting this variable to causes remap processing to take place
> +   on a dedicated thread pool, freeing the network threads to service
> +   additional requests.
> +

What's the consequence of doing that?

>  Sockets
>  =======
>  
> 
> 

-- 
Igor Galić

Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 8716 7A9F 989B ABD5 100F  4008 F266 55D6 2998 1641