You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by GitBox <gi...@apache.org> on 2022/09/25 08:44:04 UTC
[GitHub] [bigtop] yamasakisua opened a new pull request, #1026: BIGTOP-3828: Docker network resource continues to remain when use doc…
yamasakisua opened a new pull request, #1026:
URL: https://github.com/apache/bigtop/pull/1026
https://issues.apache.org/jira/browse/BIGTOP-3828
The option -d or --destroy in docker-hadoop.sh can destroy cluster by provisioner id, but the network resource is remaining after deletion.
Add steps to romeve network resources in -d option if network is exists.
The network is created as "$PROVISION_ID + _default"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims merged pull request #1026: BIGTOP-3828: Docker network resource continues to remain when use doc…
Posted by GitBox <gi...@apache.org>.
iwasakims merged PR #1026:
URL: https://github.com/apache/bigtop/pull/1026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] yamasakisua commented on a diff in pull request #1026: BIGTOP-3828: Docker network resource continues to remain when use doc…
Posted by GitBox <gi...@apache.org>.
yamasakisua commented on code in PR #1026:
URL: https://github.com/apache/bigtop/pull/1026#discussion_r980713360
##########
provisioner/docker/docker-hadoop.sh:
##########
@@ -211,10 +211,16 @@ destroy() {
else
get_nodes
docker exec ${NODES[0]} bash -c "umount /etc/hosts; rm -f /etc/hosts"
+ NETWORK_ID=`docker network ls | grep ${PROVISION_ID}_default`
Review Comment:
Thank you for comment @iwasakims
I try to replace grep with docker option and push it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims commented on a diff in pull request #1026: BIGTOP-3828: Docker network resource continues to remain when use doc…
Posted by GitBox <gi...@apache.org>.
iwasakims commented on code in PR #1026:
URL: https://github.com/apache/bigtop/pull/1026#discussion_r980147196
##########
provisioner/docker/docker-hadoop.sh:
##########
@@ -211,10 +211,16 @@ destroy() {
else
get_nodes
docker exec ${NODES[0]} bash -c "umount /etc/hosts; rm -f /etc/hosts"
+ NETWORK_ID=`docker network ls | grep ${PROVISION_ID}_default`
Review Comment:
How about using built-in `--filter` option instead of grep? @yamasakisua
```
$ docker network ls --quiet --filter name=20220926_134846_r4742_default
f4741fc073a1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org