You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/20 15:32:44 UTC

[GitHub] [arrow-datafusion] Dandandan commented on a diff in pull request #3545: Use `fetch` limit in get_sorted_iter

Dandandan commented on code in PR #3545:
URL: https://github.com/apache/arrow-datafusion/pull/3545#discussion_r975524901


##########
datafusion/core/src/physical_plan/sorts/sort.rs:
##########
@@ -273,6 +275,7 @@ impl MemoryConsumer for ExternalSorter {
             &self.expr,
             self.session_config.batch_size(),
             tracking_metrics,
+            self.fetch,

Review Comment:
   Nice thing is that it also reduces disk spilling, as sort + limit is done before writing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org