You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/01/08 03:29:16 UTC
[GitHub] [incubator-dolphinscheduler] liwenhe1993 opened a new pull request
#1766: Api module relp server module/1756
liwenhe1993 opened a new pull request #1766: Api module relp server module/1756
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1766
## *Tips*
- *Thanks very much for contributing to Apache DolphinScheduler.*
- *Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds checkstyle plugin.)*
## Brief change log
*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] Technoboy- commented on issue #1766:
Api module relp server module/1756
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on issue #1766: Api module relp server module/1756
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1766#issuecomment-575019123
@qiaozhanwei
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #1766:
Api module relp server module/1756
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #1766: Api module relp server module/1756
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1766#issuecomment-576163712
excellent
Please send mail to me(dailidong66@gmail.com) or add my wechat: 510570367, we can take deep communication , when added, please tell me your github id, thx
looking forward to your next contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #1766:
Api module relp server module/1756
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #1766: Api module relp server module/1756
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1766#issuecomment-576161905
> please resolve conflict
I resolved
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong merged pull request #1766:
Api module relp server module/1756
Posted by GitBox <gi...@apache.org>.
dailidong merged pull request #1766: Api module relp server module/1756
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1766
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] qiaozhanwei commented on issue #1766:
Api module relp server module/1756
Posted by GitBox <gi...@apache.org>.
qiaozhanwei commented on issue #1766: Api module relp server module/1756
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1766#issuecomment-575020947
please resolve conflict
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue
#1766: Api module relp server module/1756
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #1766: Api module relp server module/1756
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1766#issuecomment-571877968
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1766&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/C.png' alt='C' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1766&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1766&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1766&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/B.png' alt='B' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1766&resolved=false&types=VULNERABILITY) [7 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1766&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1766&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1766&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1766&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1766&resolved=false&types=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1766&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1766&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1766&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1766&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1766&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1766:
Api module relp server module/1756
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1766: Api module relp server module/1756
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1766#issuecomment-571877389
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1766?src=pr&el=h1) Report
> Merging [#1766](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1766?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/995b5ca4a16097d6ce82ad1d8255534fdac2264b?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1766?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1766 +/- ##
==========================================
- Coverage 20.22% 20.22% -0.01%
==========================================
Files 290 290
Lines 14082 14080 -2
Branches 2376 2376
==========================================
- Hits 2848 2847 -1
+ Misses 10908 10907 -1
Partials 326 326
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1766?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...e/dolphinscheduler/server/master/MasterServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1766/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9NYXN0ZXJTZXJ2ZXIuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
| [...olphinscheduler/api/CombinedApplicationServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1766/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL0NvbWJpbmVkQXBwbGljYXRpb25TZXJ2ZXIuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
| [...olphinscheduler/dao/quartz/ProcessScheduleJob.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1766/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3F1YXJ0ei9Qcm9jZXNzU2NoZWR1bGVKb2IuamF2YQ==) | `0% <ø> (ø)` | |
| [...dolphinscheduler/api/service/SchedulerService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1766/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvU2NoZWR1bGVyU2VydmljZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...e/dolphinscheduler/dao/quartz/QuartzExecutors.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1766/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3F1YXJ0ei9RdWFydHpFeGVjdXRvcnMuamF2YQ==) | `0% <ø> (ø)` | |
| [...nscheduler/dao/quartz/DruidConnectionProvider.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1766/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3F1YXJ0ei9EcnVpZENvbm5lY3Rpb25Qcm92aWRlci5qYXZh) | `0% <ø> (ø)` | |
| [...scheduler/alert/template/AlertTemplateFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1766/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlRmFjdG9yeS5qYXZh) | `42.85% <0%> (-14.29%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1766?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1766?src=pr&el=footer). Last update [995b5ca...fb93bc4](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1766?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services