You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Mike Percy <mp...@apache.org> on 2013/04/15 02:09:11 UTC
Review Request: FLUME-1948: plugins.d directory(ies) should be separately
overridable, independent of FLUME_HOME
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10453/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Added capability to specify one or more plugins directories on the command line.
This addresses bug FLUME-1948.
https://issues.apache.org/jira/browse/FLUME-1948
Diffs
-----
bin/flume-ng ee86c95
Diff: https://reviews.apache.org/r/10453/diff/
Testing
-------
Manually tested with config file and 2 plugins.d directories
Thanks,
Mike Percy
Re: Review Request: FLUME-1948: plugins.d directory(ies) should be
separately overridable, independent of FLUME_HOME
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10453/#review19167
-----------------------------------------------------------
I'm not too concerned about it... we print the path used at runtime and if they expect the ability to specify the param twice, but it doesn't work. they can just look @ the help output and they should see the with their usage based on the instructions.
- Mike Percy
On April 15, 2013, 2:57 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10453/
> -----------------------------------------------------------
>
> (Updated April 15, 2013, 2:57 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Added capability to specify one or more plugins directories on the command line.
>
>
> This addresses bug FLUME-1948.
> https://issues.apache.org/jira/browse/FLUME-1948
>
>
> Diffs
> -----
>
> bin/flume-ng ee86c95
>
> Diff: https://reviews.apache.org/r/10453/diff/
>
>
> Testing
> -------
>
> Manually tested with config file and 2 plugins.d directories
>
>
> Thanks,
>
> Mike Percy
>
>
Re: Review Request: FLUME-1948: plugins.d directory(ies) should be
separately overridable, independent of FLUME_HOME
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10453/#review19171
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On April 15, 2013, 2:57 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10453/
> -----------------------------------------------------------
>
> (Updated April 15, 2013, 2:57 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Added capability to specify one or more plugins directories on the command line.
>
>
> This addresses bug FLUME-1948.
> https://issues.apache.org/jira/browse/FLUME-1948
>
>
> Diffs
> -----
>
> bin/flume-ng ee86c95
>
> Diff: https://reviews.apache.org/r/10453/diff/
>
>
> Testing
> -------
>
> Manually tested with config file and 2 plugins.d directories
>
>
> Thanks,
>
> Mike Percy
>
>
Re: Review Request: FLUME-1948: plugins.d directory(ies) should be
separately overridable, independent of FLUME_HOME
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10453/
-----------------------------------------------------------
(Updated April 15, 2013, 2:57 a.m.)
Review request for Flume.
Changes
-------
Hi Jarcec, thanks for the whitespace catch. I fixed that.
Regarding the command-line option, you specify it as a colon-separated list of directories.
I just renamed it form --plugins-dirs to --plugins-path to hopefully make that less confusing.
Example usage:
./bin/flume-ng agent -c ~/work/flume/conf -f ~/work/flume/conf/flume.pluginsd-test.properties -n agent -Dflume.root.logger=DEBUG,console --plugins-path "$HOME/work/flume/plugins.d.1:$HOME/work/flume/plugins.d.2"
Description
-------
Added capability to specify one or more plugins directories on the command line.
This addresses bug FLUME-1948.
https://issues.apache.org/jira/browse/FLUME-1948
Diffs (updated)
-----
bin/flume-ng ee86c95
Diff: https://reviews.apache.org/r/10453/diff/
Testing
-------
Manually tested with config file and 2 plugins.d directories
Thanks,
Mike Percy
Re: Review Request: FLUME-1948: plugins.d directory(ies) should be
separately overridable, independent of FLUME_HOME
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10453/#review19149
-----------------------------------------------------------
Hi Mike,
thank you for your patch, I do have just a few nits:
bin/flume-ng
<https://reviews.apache.org/r/10453/#comment39725>
It seems that we always take the last --plugin-dirs parameter into account. Is it intentional or would we prefer multiple entries similarly as we are accepting with "-D"? E.g.:
opt_plugins_dirs="$opt_plugins_dirs $1"
bin/flume-ng
<https://reviews.apache.org/r/10453/#comment39726>
Nit: Trailing whitespace
bin/flume-ng
<https://reviews.apache.org/r/10453/#comment39727>
Nit: Trailing whitespace
bin/flume-ng
<https://reviews.apache.org/r/10453/#comment39728>
Nit: Trailing whitespace
Jarcec
- Jarek Cecho
On April 15, 2013, 12:09 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10453/
> -----------------------------------------------------------
>
> (Updated April 15, 2013, 12:09 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Added capability to specify one or more plugins directories on the command line.
>
>
> This addresses bug FLUME-1948.
> https://issues.apache.org/jira/browse/FLUME-1948
>
>
> Diffs
> -----
>
> bin/flume-ng ee86c95
>
> Diff: https://reviews.apache.org/r/10453/diff/
>
>
> Testing
> -------
>
> Manually tested with config file and 2 plugins.d directories
>
>
> Thanks,
>
> Mike Percy
>
>