You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by khalidhuseynov <gi...@git.apache.org> on 2018/07/02 02:37:14 UTC
[GitHub] zeppelin pull request #3046: Minor fix "ipykernel" package name shown in log...
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/3046
Minor fix "ipykernel" package name shown in logs when ipython prerequisite isn't met
### What is this PR for?
minor fix to show correct package name `ipykernel` in logs when prerequisite for ipython interpreter isn't met.
### What type of PR is it?
[ Improvement ]
### Todos
* [x] - fix naming
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
### How should this be tested?
if `ipykernel` isn't installed then it would show correct message in logs when running ipython interpreter
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/zeppelin fix/ipykernel-msg
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3046.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3046
----
commit b6a3d5c5fdcbafea4c7b99d40873df885ddffb81
Author: Khalid Huseynov <kh...@...>
Date: 2018-07-02T02:07:33Z
fix package name shown to user when not installed
commit 7a3b124f9f16b55168edf00efcade36499c52a31
Author: Khalid Huseynov <kh...@...>
Date: 2018-07-02T02:08:52Z
fix minor
----
---
[GitHub] zeppelin issue #3046: Minor fix "ipykernel" package name shown in logs when ...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3046
LGTM
---
[GitHub] zeppelin pull request #3046: Minor fix "ipykernel" package name shown in log...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3046
---