You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2016/11/11 11:06:45 UTC

[GitHub] zeppelin pull request #1622: [ZEPPELIN-1652] Fix cursor move on double click...

GitHub user minahlee opened a pull request:

    https://github.com/apache/zeppelin/pull/1622

    [ZEPPELIN-1652] Fix cursor move on double click in markdown editor

    ### What is this PR for?
    
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    [ZEPPELIN-1652](https://issues.apache.org/jira/browse/ZEPPELIN-1652)
    
    ### How should this be tested?
    1. Type `%md ### Hello Zeppelin`
    2. Double click Hello in editor
    3. See if Hello stay highlighted
    
    ### Screenshots (if appropriate)
    **Before**
    ![nov-11-2016 12-04-44](https://cloud.githubusercontent.com/assets/8503346/20213106/1a8f6f90-a807-11e6-8e30-8087db6ae97a.gif)
    
    
    **After**
    ![nov-11-2016 12-03-14](https://cloud.githubusercontent.com/assets/8503346/20213062/de4c75aa-a806-11e6-83ab-c917f41e5ed4.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/minahlee/zeppelin ZEPPELIN-1652

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1622.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1622
    
----
commit a944dcc6c78fa58a1617ae8bcebe9cbbdf43a3dd
Author: Mina Lee <mi...@apache.org>
Date:   2016-11-11T10:55:41Z

    Fix cursor move on double click in markdown editor bug

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1622: [ZEPPELIN-1652] Fix cursor move on double click in mar...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1622
  
    Tested and LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1622: [ZEPPELIN-1652] Fix cursor move on double click...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1622


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1622: [ZEPPELIN-1652] Fix cursor move on double click in mar...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1622
  
    Merge to master if there're no further comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---