[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #5175: add pinot upsert features to pinot common

[GitBox <gi...@apache.org>]

kishoreg commented on a change in pull request #5175: add pinot upsert features to pinot common
URL: https://github.com/apache/incubator-pinot/pull/5175#discussion_r402761371
 
 

 ##########
 File path: pinot-common/src/main/java/org/apache/pinot/common/config/TableConfig.java
 ##########
 @@ -470,6 +505,18 @@ public void setInstanceAssignmentConfigMap(
     return _fieldConfigList;
   }
 
+  public UpdateSemantic getUpdateSemantic() {
+    return _updateSemantic;
+  }
+
+  public void setUpdateSemantic(UpdateSemantic updateSemantic) {
+    _updateSemantic = updateSemantic;
+  }
+
+  public boolean isTableForUpsert() {
 
 Review comment:
   let's avoid adding additional utility methods to config classes if possible

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org