You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by GitBox <gi...@apache.org> on 2021/07/13 09:21:45 UTC
[GitHub] [atlas] mehtaanshul opened a new pull request #142: ATLAS-4358 move addition of default java patches to applyAll method
mehtaanshul opened a new pull request #142:
URL: https://github.com/apache/atlas/pull/142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [atlas] mehtaanshul commented on pull request #142: ATLAS-4358 move addition of default java patches to applyAll method
Posted by GitBox <gi...@apache.org>.
mehtaanshul commented on pull request #142:
URL: https://github.com/apache/atlas/pull/142#issuecomment-896224325
@nixonrodrigues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [atlas] nixon-atlan commented on pull request #142: ATLAS-4358 move addition of default java patches to applyAll method
Posted by GitBox <gi...@apache.org>.
nixon-atlan commented on pull request #142:
URL: https://github.com/apache/atlas/pull/142#issuecomment-920925113
cc : @ashutoshm , can you review this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [atlas] ashutoshm commented on pull request #142: ATLAS-4358 move addition of default java patches to applyAll method
Posted by GitBox <gi...@apache.org>.
ashutoshm commented on pull request #142:
URL: https://github.com/apache/atlas/pull/142#issuecomment-922011643
@mehtaanshul Thanks for the PR. I am in the process of verifying this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [atlas] ashutoshm commented on a change in pull request #142: ATLAS-4358 move addition of default java patches to applyAll method
Posted by GitBox <gi...@apache.org>.
ashutoshm commented on a change in pull request #142:
URL: https://github.com/apache/atlas/pull/142#discussion_r712333857
##########
File path: repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java
##########
@@ -48,28 +48,24 @@ public AtlasPatchManager(AtlasGraph atlasGraph, AtlasTypeRegistry typeRegistry,
this.context = new PatchContext(atlasGraph, typeRegistry, indexer, entityGraphMapper);
}
- @PostConstruct
Review comment:
This approach is fine. However, i would keep the init method in tact and just remove the @PostConstruct annotation.
Call _init_ in the _applyAll_ method.
I verified this change and it is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [atlas] sarathsubramanian commented on pull request #142: ATLAS-4358 move addition of default java patches to applyAll method
Posted by GitBox <gi...@apache.org>.
sarathsubramanian commented on pull request #142:
URL: https://github.com/apache/atlas/pull/142#issuecomment-923696458
Thanks for the details Anshul Mehta. I have a question:
Internal patch attributes like "**__createdBy, __modifiedBy, __timestamp, __modificationTimestamp, __patch.id, __patch.description, __patch.type, __patch.action, __patch.state**" are created in GraphBackedSearchIndexer which is Spring annotated component with Order(1)
The AtlasPatchService has an Order(3), so the internal indexes should be created before Patch Manager is initialized right? Do you see a race scenario where the init() happens during dependency injection of AtlasPatchManager in AtlasPatchService?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [atlas] sarathsubramanian commented on pull request #142: ATLAS-4358 move addition of default java patches to applyAll method
Posted by GitBox <gi...@apache.org>.
sarathsubramanian commented on pull request #142:
URL: https://github.com/apache/atlas/pull/142#issuecomment-922069637
missed the details from JIRA, ignore my prev comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [atlas] mehtaanshul commented on pull request #142: ATLAS-4358 move addition of default java patches to applyAll method
Posted by GitBox <gi...@apache.org>.
mehtaanshul commented on pull request #142:
URL: https://github.com/apache/atlas/pull/142#issuecomment-878926339
Issue link - https://issues.apache.org/jira/browse/ATLAS-4358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [atlas] sarathsubramanian commented on pull request #142: ATLAS-4358 move addition of default java patches to applyAll method
Posted by GitBox <gi...@apache.org>.
sarathsubramanian commented on pull request #142:
URL: https://github.com/apache/atlas/pull/142#issuecomment-922064683
@mehtaanshul , can you add an explanation on why we need to move the java patch registration from init() to applyAll() method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [atlas] mehtaanshul edited a comment on pull request #142: ATLAS-4358 move addition of default java patches to applyAll method
Posted by GitBox <gi...@apache.org>.
mehtaanshul edited a comment on pull request #142:
URL: https://github.com/apache/atlas/pull/142#issuecomment-896224325
Hey @nixonrodrigues, can you please look into this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org