You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/01 13:19:53 UTC
[GitHub] [airflow] XD-DENG opened a new pull request #8667: UI Fix: ensure "started"/"ended" in TI tooltips are not shown if the job not started yet
XD-DENG opened a new pull request #8667:
URL: https://github.com/apache/airflow/pull/8667
This is to fix the UI bug identified in another PR https://github.com/apache/airflow/pull/8663#issuecomment-622344999
This must be applied together with https://github.com/apache/airflow/pull/8663, otherwise the tooltip for DummyOperators will be shown incorrectly.
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #8667: UI Fix: ensure "started"/"ended" in TI tooltips are not shown if the job not started yet
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #8667:
URL: https://github.com/apache/airflow/pull/8667#issuecomment-622457082
Will merge after https://github.com/apache/airflow/pull/8663 is merged, due to the dependency mentioned in the description above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #8667: UI Fix: ensure "started"/"ended" in TI tooltips are not shown if the job not started yet
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #8667:
URL: https://github.com/apache/airflow/pull/8667#issuecomment-622385439
Hi @ashb , please have a look.
This is a simple fix by re-ordering a few lines, and it seems to me the result after the fix is consistent with your original intention in your JS code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org