[GitHub] [logging-log4j2] rgoers commented on a change in pull request #481: LOG4J2-3060 Fix integer overflow in DefaultErrorHandler

[GitBox <gi...@apache.org>]

rgoers commented on a change in pull request #481:
URL: https://github.com/apache/logging-log4j2/pull/481#discussion_r654555057



##########
File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/DefaultErrorHandler.java
##########
@@ -84,14 +75,24 @@ public void error(final String msg, final Throwable t) {
      */
     @Override
     public void error(final String msg, final LogEvent event, final Throwable t) {
+        handleErrorMessage(msg, t);
+        if (!appender.ignoreExceptions() && t != null && !(t instanceof AppenderLoggingException)) {
+            throw new AppenderLoggingException(msg, t);
+        }
+    }
+
+    private void handleErrorMessage(

Review comment:
       All the parameters really should be on the method declaration since it isn't going to exceed the max line length.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org