You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/11/10 02:29:13 UTC

[GitHub] [hadoop] iwasakims commented on a change in pull request #2350: HADOOP-17292. Using lz4-java in Lz4Codec

iwasakims commented on a change in pull request #2350:
URL: https://github.com/apache/hadoop/pull/2350#discussion_r520245741



##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/lz4/Lz4Decompressor.java
##########
@@ -22,8 +22,9 @@
 import java.nio.Buffer;
 import java.nio.ByteBuffer;
 
+import net.jpountz.lz4.LZ4Factory;
+import net.jpountz.lz4.LZ4SafeDecompressor;

Review comment:
       @viirya I think steveloughran is mentioning about the order of imports and blank line between import blocks.
   https://github.com/steveloughran/formality/blob/master/styleguide/styleguide.md#imports
   
   While the original file violates the coding stantdard and we usually avoid large diff just for fixing formatting issue, it would be ok to fix a few lines here.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org