You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Soumyakanti Das (Code Review)" <ge...@cloudera.org> on 2023/05/06 00:49:04 UTC

[Impala-ASF-CR] IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method

Soumyakanti Das has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19852


Change subject: IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method
......................................................................

IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method

getLastModifiedTime() of Function.java assumes that if the UDF is not a BUILTIN
and if the location is not null, it is a non-empty string. However, we may have
UDFs with an empty location if they are in the install location and loaded at
init time.

This patch introduces an isBuiltin() method that checks if the function is
BUILTIN, or if the location is blank.

Change-Id: Ia6035d1a21e7222f0e95f984a0f4022ba2e89d9f
---
M fe/src/main/java/org/apache/impala/catalog/Function.java
1 file changed, 11 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/19852/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6035d1a21e7222f0e95f984a0f4022ba2e89d9f
Gerrit-Change-Number: 19852
Gerrit-PatchSet: 1
Gerrit-Owner: Soumyakanti Das <so...@cloudera.com>

[Impala-ASF-CR] IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19852 )

Change subject: IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9313/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/19852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6035d1a21e7222f0e95f984a0f4022ba2e89d9f
Gerrit-Change-Number: 19852
Gerrit-PatchSet: 2
Gerrit-Owner: Soumyakanti Das <so...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Soumyakanti Das <so...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 May 2023 16:51:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19852 )

Change subject: IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6035d1a21e7222f0e95f984a0f4022ba2e89d9f
Gerrit-Change-Number: 19852
Gerrit-PatchSet: 4
Gerrit-Owner: Soumyakanti Das <so...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Soumyakanti Das <so...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 May 2023 06:59:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19852 )

Change subject: IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9320/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/19852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6035d1a21e7222f0e95f984a0f4022ba2e89d9f
Gerrit-Change-Number: 19852
Gerrit-PatchSet: 3
Gerrit-Owner: Soumyakanti Das <so...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Soumyakanti Das <so...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 May 2023 18:35:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19852 )

Change subject: IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19852/1/fe/src/main/java/org/apache/impala/catalog/Function.java
File fe/src/main/java/org/apache/impala/catalog/Function.java:

http://gerrit.cloudera.org:8080/#/c/19852/1/fe/src/main/java/org/apache/impala/catalog/Function.java@461
PS1, Line 461:     return getBinaryType() == TFunctionBinaryType.BUILTIN ||
Can you check in the second case that it is a JAVA function?


http://gerrit.cloudera.org:8080/#/c/19852/1/fe/src/main/java/org/apache/impala/catalog/Function.java@462
PS1, Line 462:  getLocation() == null || getLocation().toString().isEmpty();
Do we need to allow both? null could be used to mark builtin functions and empty string could be caught by a precondition check



-- 
To view, visit http://gerrit.cloudera.org:8080/19852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6035d1a21e7222f0e95f984a0f4022ba2e89d9f
Gerrit-Change-Number: 19852
Gerrit-PatchSet: 1
Gerrit-Owner: Soumyakanti Das <so...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 May 2023 06:21:09 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19852 )

Change subject: IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9321/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/19852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6035d1a21e7222f0e95f984a0f4022ba2e89d9f
Gerrit-Change-Number: 19852
Gerrit-PatchSet: 4
Gerrit-Owner: Soumyakanti Das <so...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Soumyakanti Das <so...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 May 2023 06:59:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19852 )

Change subject: IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6035d1a21e7222f0e95f984a0f4022ba2e89d9f
Gerrit-Change-Number: 19852
Gerrit-PatchSet: 4
Gerrit-Owner: Soumyakanti Das <so...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Soumyakanti Das <so...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 May 2023 12:22:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method

Posted by "Soumyakanti Das (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19852

to look at the new patch set (#3).

Change subject: IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method
......................................................................

IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method

getLastModifiedTime() of Function.java assumes that if the UDF is not a BUILTIN
and if the location is not null, it is a non-empty string. However, we may have
UDFs with an empty location if they are in the install location and loaded at
init time.

This patch introduces an isBuiltinOrJava() method that checks if the function is
BUILTIN, or a JAVA function with blank location.

Change-Id: Ia6035d1a21e7222f0e95f984a0f4022ba2e89d9f
---
M fe/src/main/java/org/apache/impala/catalog/Function.java
1 file changed, 12 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/19852/3
-- 
To view, visit http://gerrit.cloudera.org:8080/19852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia6035d1a21e7222f0e95f984a0f4022ba2e89d9f
Gerrit-Change-Number: 19852
Gerrit-PatchSet: 3
Gerrit-Owner: Soumyakanti Das <so...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Soumyakanti Das <so...@cloudera.com>

[Impala-ASF-CR] IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19852 )

Change subject: IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13050/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6035d1a21e7222f0e95f984a0f4022ba2e89d9f
Gerrit-Change-Number: 19852
Gerrit-PatchSet: 3
Gerrit-Owner: Soumyakanti Das <so...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Soumyakanti Das <so...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 May 2023 18:52:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method

Posted by "Soumyakanti Das (Code Review)" <ge...@cloudera.org>.
Soumyakanti Das has posted comments on this change. ( http://gerrit.cloudera.org:8080/19852 )

Change subject: IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19852/1/fe/src/main/java/org/apache/impala/catalog/Function.java
File fe/src/main/java/org/apache/impala/catalog/Function.java:

http://gerrit.cloudera.org:8080/#/c/19852/1/fe/src/main/java/org/apache/impala/catalog/Function.java@462
PS1, Line 462:  getLocation() == null || getLocation().toString().isEmpty();
> Do we need to allow both? null could be used to mark builtin functions and 
I think we should allow both as we can provide empty strings for classes in the local install directory.



-- 
To view, visit http://gerrit.cloudera.org:8080/19852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6035d1a21e7222f0e95f984a0f4022ba2e89d9f
Gerrit-Change-Number: 19852
Gerrit-PatchSet: 1
Gerrit-Owner: Soumyakanti Das <so...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Soumyakanti Das <so...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 May 2023 20:59:32 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19852 )

Change subject: IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6035d1a21e7222f0e95f984a0f4022ba2e89d9f
Gerrit-Change-Number: 19852
Gerrit-PatchSet: 3
Gerrit-Owner: Soumyakanti Das <so...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Soumyakanti Das <so...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 May 2023 06:59:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19852 )

Change subject: IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6035d1a21e7222f0e95f984a0f4022ba2e89d9f
Gerrit-Change-Number: 19852
Gerrit-PatchSet: 1
Gerrit-Owner: Soumyakanti Das <so...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 06 May 2023 06:03:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19852 )

Change subject: IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9320/


-- 
To view, visit http://gerrit.cloudera.org:8080/19852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6035d1a21e7222f0e95f984a0f4022ba2e89d9f
Gerrit-Change-Number: 19852
Gerrit-PatchSet: 3
Gerrit-Owner: Soumyakanti Das <so...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Soumyakanti Das <so...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 May 2023 23:57:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19852 )

Change subject: IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12956/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6035d1a21e7222f0e95f984a0f4022ba2e89d9f
Gerrit-Change-Number: 19852
Gerrit-PatchSet: 1
Gerrit-Owner: Soumyakanti Das <so...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 06 May 2023 01:09:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19852 )

Change subject: IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9291/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/19852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6035d1a21e7222f0e95f984a0f4022ba2e89d9f
Gerrit-Change-Number: 19852
Gerrit-PatchSet: 1
Gerrit-Owner: Soumyakanti Das <so...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 06 May 2023 00:52:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method

Posted by "Soumyakanti Das (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19852

to look at the new patch set (#2).

Change subject: IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method
......................................................................

IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method

getLastModifiedTime() of Function.java assumes that if the UDF is not a BUILTIN
and if the location is not null, it is a non-empty string. However, we may have
UDFs with an empty location if they are in the install location and loaded at
init time.

This patch introduces an isBuiltinOrJava() method that checks if the function is
BUILTIN, JAVA function, or if the location is blank.

Change-Id: Ia6035d1a21e7222f0e95f984a0f4022ba2e89d9f
---
M fe/src/main/java/org/apache/impala/catalog/Function.java
1 file changed, 12 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/19852/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia6035d1a21e7222f0e95f984a0f4022ba2e89d9f
Gerrit-Change-Number: 19852
Gerrit-PatchSet: 2
Gerrit-Owner: Soumyakanti Das <so...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Soumyakanti Das <so...@cloudera.com>

[Impala-ASF-CR] IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19852 )

Change subject: IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9313/


-- 
To view, visit http://gerrit.cloudera.org:8080/19852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6035d1a21e7222f0e95f984a0f4022ba2e89d9f
Gerrit-Change-Number: 19852
Gerrit-PatchSet: 2
Gerrit-Owner: Soumyakanti Das <so...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Soumyakanti Das <so...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 May 2023 22:13:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19852 )

Change subject: IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13022/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6035d1a21e7222f0e95f984a0f4022ba2e89d9f
Gerrit-Change-Number: 19852
Gerrit-PatchSet: 2
Gerrit-Owner: Soumyakanti Das <so...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Soumyakanti Das <so...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 May 2023 17:12:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19852 )

Change subject: IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method
......................................................................

IMPALA-12121: Add non empty check for UDF location in getLastModifiedTime method

getLastModifiedTime() of Function.java assumes that if the UDF is not a BUILTIN
and if the location is not null, it is a non-empty string. However, we may have
UDFs with an empty location if they are in the install location and loaded at
init time.

This patch introduces an isBuiltinOrJava() method that checks if the function is
BUILTIN, or a JAVA function with blank location.

Change-Id: Ia6035d1a21e7222f0e95f984a0f4022ba2e89d9f
Reviewed-on: http://gerrit.cloudera.org:8080/19852
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/catalog/Function.java
1 file changed, 12 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/19852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6035d1a21e7222f0e95f984a0f4022ba2e89d9f
Gerrit-Change-Number: 19852
Gerrit-PatchSet: 5
Gerrit-Owner: Soumyakanti Das <so...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Soumyakanti Das <so...@cloudera.com>