You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "sankalp kohli (JIRA)" <ji...@apache.org> on 2014/06/06 19:50:02 UTC
[jira] [Comment Edited] (CASSANDRA-7359) Optimize locking in
PaxosState
[ https://issues.apache.org/jira/browse/CASSANDRA-7359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020122#comment-14020122 ]
sankalp kohli edited comment on CASSANDRA-7359 at 6/6/14 5:49 PM:
------------------------------------------------------------------
"Would simply replacing the Object[] array with Guava's Striped make you happy?"
Yup makes me happy :)
was (Author: kohlisankalp):
Would simply replacing the Object[] array with Guava's Striped make you happy?
Yup makes me happy :)
> Optimize locking in PaxosState
> ------------------------------
>
> Key: CASSANDRA-7359
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7359
> Project: Cassandra
> Issue Type: Improvement
> Reporter: sankalp kohli
> Assignee: Benedict
> Priority: Minor
> Attachments: 7359.txt
>
>
> In PaxosState, we want to lock on same rows and have created 1024 size array with java Objects in them to be used for locking.
> We should replace these Objects with some Lock so that we can know whether there is contention trying to acquire a lock for different rows.
> We can achieve that by also storing the hash of the row which acquired the lock. This will tell us if this needs to be improved.
> Here is an improvement which I was thinking about.
> Say two rows A and B map to the same 1024 bucket which we have. A get the lock and B has to wait. Here B can check if his hash is different and create a new object and chain it to the other one.
> This looks close to a hashMap with chaining for same key.
> The hard part will be removing the entries no longer being used.
--
This message was sent by Atlassian JIRA
(v6.2#6252)