[GitHub] [hive] pvargacl commented on a change in pull request #1224: HIVE-23805: Provide ValidTxnList to AcidUtils::getAcidState

[GitBox <gi...@apache.org>]

pvargacl commented on a change in pull request #1224:
URL: https://github.com/apache/hive/pull/1224#discussion_r451446059



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -1262,8 +1262,8 @@ public static boolean isAcid(FileSystem fileSystem, Path directory,
    * @throws IOException on filesystem errors
    */
   public static Directory getAcidState(FileSystem fileSystem, Path candidateDirectory, Configuration conf,
-      ValidWriteIdList writeIdList, Ref<Boolean> useFileIds, boolean ignoreEmptyFiles) throws IOException {
-    return getAcidState(fileSystem, candidateDirectory, conf, writeIdList, useFileIds, ignoreEmptyFiles, null);
+      ValidWriteIdList writeIdList, ValidTxnList validTxnList, Ref<Boolean> useFileIds, boolean ignoreEmptyFiles) throws IOException {
+    return getAcidState(fileSystem, candidateDirectory, conf, writeIdList, validTxnList, useFileIds, ignoreEmptyFiles, null);

Review comment:
       I will create a separate issue to change getAcidState to get just one parameter with builder pattern, because this is getting out of hand




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org