You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/23 20:37:06 UTC

[GitHub] [arrow-rs] tfeda commented on a diff in pull request #1612: Update datatypes in parquet::basic::LogicalType

tfeda commented on code in PR #1612:
URL: https://github.com/apache/arrow-rs/pull/1612#discussion_r857033174


##########
parquet/src/arrow/schema.rs:
##########
@@ -678,20 +678,20 @@ impl ParquetTypeConverter<'_> {
                 (32, false) => Ok(DataType::UInt32),
                 _ => Err(ArrowError(format!(
                     "Cannot create INT32 physical type from {:?}",
-                    t
+                    self.schema.get_basic_info().logical_type(), 

Review Comment:
   I've spent some time looking into this. This syntax causes `t` to be evaluated as a `LogicalType` rather than a `LogicalType::IntegerType`. I then can't use it for `match (t.bit_width, t.is_signed) `. I also tried `t @ LogicalType::Integer { bit_width, is_signed }`, but then I run into borrow issues. Is there some order-of-op trick I'm missing?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org