You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jedcunningham (via GitHub)" <gi...@apache.org> on 2026/01/30 18:41:10 UTC

[I] Status of testing of Apache Airflow Helm Chart 1.19.0rc1 [airflow]

jedcunningham opened a new issue, #61268:
URL: https://github.com/apache/airflow/issues/61268

   ### Body
   
   We are kindly requesting that contributors to [Apache Airflow Helm Chart 1.19.0rc1](https://dist.apache.org/repos/dist/dev/airflow/helm-chart/1.19.0rc1) help test the RC.
   
   Please let us know by commenting if the issue is addressed in the latest RC.
   
   - [ ] [add readiness and liveliness support for git sync relay sidecars (#50218)](https://github.com/apache/airflow/pull/50218): @pgvishnuram
   - [ ] [Added support for job launcher (#52024)](https://github.com/apache/airflow/pull/52024): @avikbesu @rbm897
        Linked issues:
        - [KubernetesJobOperator is not creating jobs using official chart (#50595)](https://github.com/apache/airflow/issues/50595)
   - [ ] [enable optional subPath for logs volume mount (#52350)](https://github.com/apache/airflow/pull/52350): @gbloisi-openaire
   - [ ] [Separate workers service accounts (#52357)](https://github.com/apache/airflow/pull/52357): @Miretpl
        Linked issues:
        - [Introduce workers.celery and workers.kubernetes config sections (#51460)](https://github.com/apache/airflow/pull/51460)
   - [ ] [Add Horizontal Pod Autoscaler (HPA) Support for Airflow API Server (#52392)](https://github.com/apache/airflow/pull/52392): @carlos54 @jscheffl @HsiuChuanHsu
        Linked issues:
        - [Support HPA and topologySpreadConstraints for apiServer (#51935)](https://github.com/apache/airflow/issues/51935)
   - [ ] [Fix KEDA Query to Use executor Field Instead of queue for Multiple Executors (#52840)](https://github.com/apache/airflow/pull/52840): @noamst-monday @HsiuChuanHsu
        Linked issues:
        - [KEDA Query for multiple executors should use "executor" field instead of "queue" (#49001)](https://github.com/apache/airflow/issues/49001)
   - [ ] [[helm] Add missing `airflow.fullname` on kubernetes objects (#52953)](https://github.com/apache/airflow/pull/52953): @zyst1988 @albundy83
        Linked issues:
        - [Missing webserver-secret-key-secret (#53375)](https://github.com/apache/airflow/issues/53375)
   - [ ] [fix: Add api-server support for k8s pod template (#53533)](https://github.com/apache/airflow/pull/53533): @LipuFei
   - [ ] [fix: Trim non-alphanumeric characters from the executor label (#53534)](https://github.com/apache/airflow/pull/53534): @LipuFei
   - [ ] [Fix Syntax Error in Airflow Job Launcher Role (#53822)](https://github.com/apache/airflow/pull/53822): @rbm897 @HsiuChuanHsu
        Linked issues:
        - [Added support for job launcher (#52024)](https://github.com/apache/airflow/pull/52024)
   - [ ] [Allow overriding schedulerName on worker/tasks pods (#53983)](https://github.com/apache/airflow/pull/53983): @SamWheating
   - [ ] [update git-sync to 4.4.2 (#54085)](https://github.com/apache/airflow/pull/54085): @eladkal
   - [ ] [Allow setting restartPolicy for batch jobs in chart (#54354)](https://github.com/apache/airflow/pull/54354): @ihorlukianov
   - [ ] [fix helm schema validation for executor value (#54682)](https://github.com/apache/airflow/pull/54682): @chrisfregly-angi @chrisfregly
        Linked issues:
        - [Helm Schema Validation Prevents Specifying Custom Executors (#54673)](https://github.com/apache/airflow/issues/54673)
   - [ ] [Add apiServer to helm chart container resources docs (#54698)](https://github.com/apache/airflow/pull/54698): @Aakcht
   - [ ] [helm: statsd deployment volume mount without subpath for live reloading (#54986)](https://github.com/apache/airflow/pull/54986): @MaicoTimmerman
   - [ ] [Make term Dag consistent in docs v2 (#55099)](https://github.com/apache/airflow/pull/55099): @jscheffl
        Linked issues:
        - [Make term Dag consistent in docs (#55097)](https://github.com/apache/airflow/pull/55097)
   - [ ] [Update webserver secret note in Helm chart NOTES.txt and prod guide (#55106)](https://github.com/apache/airflow/pull/55106): @amordoch
   - [ ] [Fix KEDA query for Kubernetes Executor (#55559)](https://github.com/apache/airflow/pull/55559): @wolfdn
   - [ ] [Add EdgeExecutor to KEDA query (#55560)](https://github.com/apache/airflow/pull/55560): @wolfdn
   - [ ] [Temporary fix to Bitnami psql chart licensing issues (#55820)](https://github.com/apache/airflow/pull/55820): @amoghrajesh
   - [ ] [Customize statsd dagprocessor labels (#55832)](https://github.com/apache/airflow/pull/55832): @goncalo-m-c
   - [ ] [Create an explicit control for createUserJob (#56057)](https://github.com/apache/airflow/pull/56057): @prakharcode @markhc
        Linked issues:
        - [Airflow v3 user creation command fails (#51304)](https://github.com/apache/airflow/issues/51304)
   - [ ] [fix(docs): handle array parameter flattening in _get_params (#56389)](https://github.com/apache/airflow/pull/56389): @prdai @jscheffl
   - [ ] [fix: scheduler, triggerer, worker airflow components have inconsistent log volume (#56418)](https://github.com/apache/airflow/pull/56418): @danielhoherd @rich7420
        Linked issues:
        - [scheduler, triggerer, worker airflow components have inconsistent log volume (#56015)](https://github.com/apache/airflow/issues/56015)
   - [ ] [Add ability to disable apiserver from the helm chart using apiServer enabled (#56493)](https://github.com/apache/airflow/pull/56493): @bluek1te @jscheffl
   - [ ] [Fixing YAML block scalar when providing sshKey for git-sync (#56716)](https://github.com/apache/airflow/pull/56716): @RobinM-code
   - [ ] [Fix formatting in production-guide.rst (#56754)](https://github.com/apache/airflow/pull/56754): @Spasnof
   - [ ] [Move triggerer from pod-log-reader-role to pod-launcher-role  (#56872)](https://github.com/apache/airflow/pull/56872): @AutomationDev85
   - [ ] [Extract prek hooks for Helm (#57263)](https://github.com/apache/airflow/pull/57263): @jscheffl
   - [ ] [Fix wrong path pattern after moving prek check to chart folder (#57311)](https://github.com/apache/airflow/pull/57311): @jscheffl
   - [ ] [Enable ruff PLW2101,PLW2901,PLW3301 rule (#57700)](https://github.com/apache/airflow/pull/57700): @jscheffl
   - [ ] [Synchronize default versions in all split .pre-commit-config.yaml (#57851)](https://github.com/apache/airflow/pull/57851): @potiuk
   - [ ] [Missing SCC Role bindings for redis and api-server (#57985)](https://github.com/apache/airflow/pull/57985): @ronaldorcampos
   - [ ] [Add registry.secretNames and registry.connections options to Helm chart (#58094)](https://github.com/apache/airflow/pull/58094): @invalid-email-address @aeroyorch
        Linked issues:
        - [Support multiple image pull secrets in Helm values (#57615)](https://github.com/apache/airflow/issues/57615)
   - [ ] [Convert all airflow distributions to be compliant with ASF requirements (#58138)](https://github.com/apache/airflow/pull/58138): @CalvinKirs @potiuk
        Linked issues:
        - [Add NOTICE File (#58131)](https://github.com/apache/airflow/pull/58131)
   - [ ] [Add database cleanup cronjob to clean old records (#58155)](https://github.com/apache/airflow/pull/58155): @ronaldorcampos
   - [ ] [Keda best practices + better documentation (#10358) (#58246)](https://github.com/apache/airflow/pull/58246): @FoxHelms
   - [ ] [Doc: update chart info about built-in secrets and environment variables (#58317)](https://github.com/apache/airflow/pull/58317): @Aakcht
   - [ ] [helm: ensure graceful redis shutdown (#58432)](https://github.com/apache/airflow/pull/58432): @arkadiuszbach
   - [ ] [Remove FastAPI upper constraint (#58524)](https://github.com/apache/airflow/pull/58524): @pierrejeambrun
   - [ ] [Chart: Enhance Celery Worker Sets support for multi-queue configurations (#58547)](https://github.com/apache/airflow/pull/58547): @glennhsh @RonaldGalea @HsiuChuanHsu
        Linked issues:
        - [Deploy multiple (celery) workers with the Helm Chart (#34219)](https://github.com/apache/airflow/issues/34219)
        - [Add support for multiple Celery worker groups with queue-specific configurations in Helm chart (#56591)](https://github.com/apache/airflow/issues/56591)
   - [ ] [Extra tests for db cleanup and fix cronjob image pull secrets (#58626)](https://github.com/apache/airflow/pull/58626): @ronaldorcampos
   - [ ] [Fix flower network policy condition when multiple executors (#58635)](https://github.com/apache/airflow/pull/58635): @ronaldorcampos
   - [ ] [Add database cleanup options and remove deprecated securityContext field (#58663)](https://github.com/apache/airflow/pull/58663): @invalid-email-address @aeroyorch
   - [ ] [Make cleanup-pods cronjob conditional on kubernetes executor (#58695)](https://github.com/apache/airflow/pull/58695): @ronaldorcampos
   - [ ] [Add database cleanup docs to Helm productions docs (#58707)](https://github.com/apache/airflow/pull/58707): @invalid-email-address @aeroyorch
   - [ ] [helm: correctly derive celery sync_parallelism from scheduler CPU limits (#58733)](https://github.com/apache/airflow/pull/58733): @arkadiuszbach
   - [ ] [Fix Liveness / Readiness / Startup probe path for Airflow 3.x #58129 (#58734)](https://github.com/apache/airflow/pull/58734): @jvoravong @jason810496 @gichul-hong
        Linked issues:
        - [Liveness / Readiness / Startup probe path for Airflow 3.x (#58129)](https://github.com/apache/airflow/issues/58129)
   - [ ] [Helm chart: start Redis directly, not via shell (#58790)](https://github.com/apache/airflow/pull/58790): @arkadiuszbach @amordoch
        Linked issues:
        - [helm: ensure graceful redis shutdown (#58432)](https://github.com/apache/airflow/pull/58432)
   - [ ] [Extend airflow_ti_running metrics by scheduled, queued and deferred (#58819)](https://github.com/apache/airflow/pull/58819): @AutomationDev85
   - [ ] [fix(helm): allow additional PodDisruptionBudget config properties (#58864)](https://github.com/apache/airflow/pull/58864): @Vishalup29
   - [ ] [Add pdbs for triggerer and workers (#59068)](https://github.com/apache/airflow/pull/59068): @mrrsm
   - [ ] [Optimize K8s API usage for watching events (#59080)](https://github.com/apache/airflow/pull/59080): @wolfdn
   - [ ] [Fix ingress Helm Chart notes generation (#59122)](https://github.com/apache/airflow/pull/59122): @Miretpl
   - [ ] [Ensure that git-sync actually runs when dags.gitSync.enabled=true and dags.persistence.enabled=true (#59123)](https://github.com/apache/airflow/pull/59123): @jstaf
   - [ ] [Add support for disabling SA token automount for Scheduler (#59156)](https://github.com/apache/airflow/pull/59156): @dan-osterrath @dano-nx @fsellecchia
        Linked issues:
        - [Ability to set automountServiceAccountToken in values.yaml (#30722)](https://github.com/apache/airflow/issues/30722)
        - [Disable automountServiceAccountToken for Kubernetes executor (#59099)](https://github.com/apache/airflow/issues/59099)
   - [ ] [Remove getting labels of unexisted sections (#59213)](https://github.com/apache/airflow/pull/59213): @Miretpl
   - [ ] [Add newsfragment for 52357 PR (#59214)](https://github.com/apache/airflow/pull/59214): @Miretpl
   - [ ] [[Chart] Fix rendering condition of "git_sync_ssh_key_volume" (#59418)](https://github.com/apache/airflow/pull/59418): @zezaeoh
   - [ ] [Add workers.celery.replicas field (#59730)](https://github.com/apache/airflow/pull/59730): @Miretpl
   - [ ] [[helm] Remove defaultUser of apiServer in values.schema.json (#59762)](https://github.com/apache/airflow/pull/59762): @nhuantho
   - [ ] [[helm] Isolate defaultUser handling in createUserJob (#59767)](https://github.com/apache/airflow/pull/59767): @nhuantho
   - [ ] [Chart: add custom envs to database cleanup (#59804)](https://github.com/apache/airflow/pull/59804): @Aakcht
   - [ ] [add redis statefulset persistentVolumeClaimRetentionPolicy support (#59955)](https://github.com/apache/airflow/pull/59955): @pgvishnuram
   - [ ] [Add workers.celery.revisionHistoryLimit field (#60056)](https://github.com/apache/airflow/pull/60056): @Miretpl
   - [ ] [Add workers.celery.command & workers.kubernetes.command (#60067)](https://github.com/apache/airflow/pull/60067): @Miretpl
   - [ ] [Add checksum for JWT secret in API server and scheduler deployments i… (#60111)](https://github.com/apache/airflow/pull/60111): @arjav1528 @connorwang
        Linked issues:
        - [Redeployment of API server without the scheduler causes dag failure (#60040)](https://github.com/apache/airflow/issues/60040)
   - [ ] [Allow custom volumeClaimTemplates when logs.persistence.enabled is true (#60118)](https://github.com/apache/airflow/pull/60118): @arjav1528 @m4dm4rtig4n
        Linked issues:
        - [[helm-chart] 1.16.0: Cannot add custom volumeClaimTemplates to workers (#59571)](https://github.com/apache/airflow/issues/59571)
   - [ ] [Remove unneeded logic in api-server-deployment.yaml (#60147)](https://github.com/apache/airflow/pull/60147): @Miretpl
   - [ ] [Add workers.celery.args field (#60163)](https://github.com/apache/airflow/pull/60163): @Miretpl
   - [ ] [Add workers.celery.livenessProbe section (#60186)](https://github.com/apache/airflow/pull/60186): @Miretpl
   - [ ] [Add workers.celery.persistence section (#60238)](https://github.com/apache/airflow/pull/60238): @Miretpl
   - [ ] [Remove unused workers.persistence.containerLifecycleHooks field (#60239)](https://github.com/apache/airflow/pull/60239): @Miretpl @rzjfr
        Linked issues:
        - [Chart: add support for container lifecycle hooks (#32349)](https://github.com/apache/airflow/pull/32349)
        - [Add workers.celery.persistence section (#60238)](https://github.com/apache/airflow/pull/60238)
   - [ ] [ Add PodDisruptionBudget support for DAG Processor (#60294)](https://github.com/apache/airflow/pull/60294): @Arunodoy18
   - [ ] [fix(chart): allow revisionHistoryLimit to be set to 0 (#60340)](https://github.com/apache/airflow/pull/60340): @cuerty
        Linked issues:
        - [revisionHistoryLimit: 0 is silently ignored due to truthy check in templates (#60339)](https://github.com/apache/airflow/issues/60339)
   - [ ] [New year means updated Copyright notices (#60344)](https://github.com/apache/airflow/pull/60344): @potiuk
   - [ ] [Add workers.celery.updateStrategy field (#60351)](https://github.com/apache/airflow/pull/60351): @Miretpl
   - [ ] [Add workers.celery.strategy field (#60354)](https://github.com/apache/airflow/pull/60354): @Miretpl
   - [ ] [Add workers.celery.podManagementPolicy field (#60359)](https://github.com/apache/airflow/pull/60359): @Miretpl
   - [ ] [Add workers.celery.securityContexts & workers.kubernetes.securityContexts (#60396)](https://github.com/apache/airflow/pull/60396): @Miretpl
   - [ ] [Fix Compatibility of Celery Worker Sets with Workers Separation (#60420)](https://github.com/apache/airflow/pull/60420): @jedcunningham @glennhsh @csp33 @Miretpl
        Linked issues:
        - [Can't configure Kubernetes and Celery workers in Helm Chart (#28880)](https://github.com/apache/airflow/issues/28880)
        - [Chart: Enhance Celery Worker Sets support for multi-queue configurations (#58547)](https://github.com/apache/airflow/pull/58547)
   - [ ] [Add workers.celery.kerberosInitContainer field (#60427)](https://github.com/apache/airflow/pull/60427): @henry3260
   - [ ] [Docs: Clarify ingress settings for Airflow 2 vs 3 in values.yaml (#60434)](https://github.com/apache/airflow/pull/60434): @seanfariaparetointel @vighneshtule
        Linked issues:
        - [Update Helm values.yaml (#53611)](https://github.com/apache/airflow/issues/53611)
   - [ ] [Chart: Default airflow version to 3.1.6 (#60453)](https://github.com/apache/airflow/pull/60453): @ephraimbuddy
   - [ ] [Chart: fix securityContext.containers/ingress.apiServer in values.schema.json (#60575)](https://github.com/apache/airflow/pull/60575): @Aakcht
   - [ ] [Docs: Improve wording in Helm chart introduction (#60595)](https://github.com/apache/airflow/pull/60595): @dilshadshaik3031
   - [ ] [Improve dag_bundle_config_list Configuration in Airflow Helm Chart (#60645)](https://github.com/apache/airflow/pull/60645): @uplsh580
   - [ ] [Finish workers.celery.kerberosInitContainer & add workers.kubernetes.kerberosInitContainer (#60751)](https://github.com/apache/airflow/pull/60751): @Miretpl
   - [ ] [Fix missing templating in API server extraInitContainers (#60812)](https://github.com/apache/airflow/pull/60812): @subhash-0000 @thejoeejoee
        Linked issues:
        - [Missing templating in api server extra init containers (#60780)](https://github.com/apache/airflow/issues/60780)
   - [ ] [Support PR: Add TTL-enabled LRU cache for StatsD metrics aggregation (#60933)](https://github.com/apache/airflow/pull/60933): @AutomationDev85 @shubham36deshpande
   - [ ] [Move core newsfragment out of chart directory (#60994)](https://github.com/apache/airflow/pull/60994): @jedcunningham
   - [ ] [Remove workers.celery breaking change (#61049)](https://github.com/apache/airflow/pull/61049): @Miretpl
   - [ ] [Fix Keycloak provider redirect_uri to use HTTPS behind reverse proxy   (#61095)](https://github.com/apache/airflow/pull/61095): @arjav1528 @atalakey4work
        Linked issues:
        - [Airflow Keycloak provider redirect to HTTP instead of HTTPS (#60922)](https://github.com/apache/airflow/issues/60922)
   - [ ] [Fix formatting & make newsfragment #60933 match changes (#61102)](https://github.com/apache/airflow/pull/61102): @Miretpl @AutomationDev85
        Linked issues:
        - [Support PR: Add TTL-enabled LRU cache for StatsD metrics aggregation (#60933)](https://github.com/apache/airflow/pull/60933)
   - [ ] [Chart: use same bitnami postgres image as 1.18.0 (#61156)](https://github.com/apache/airflow/pull/61156): @jedcunningham @amoghrajesh
        Linked issues:
        - [Temporary fix to Bitnami psql chart licensing issues (#55820)](https://github.com/apache/airflow/pull/55820)
   
   Thanks to all who contributed to the release (probably not a complete list!):
   @bugraoz93 @rich7420 @ido177 @bluek1te @jbampton @pierrejeambrun @kaxil @noamst-monday @ihorlukianov @aeroyorch @nhuantho @henry3260 @FoxHelms @RonaldGalea @LipuFei @arjav1528 @dan-osterrath @arkadiuszbach @gbloisi-openaire @ephraimbuddy @prakharcode @connorwang @Arunodoy18 @wolfdn @gichul-hong @invalid-email-address @goncalo-m-c @carlos54 @jason810496 @m4dm4rtig4n @seanfariaparetointel @amordoch @jscheffl @Vishalup29 @MaicoTimmerman @SamWheating @HsiuChuanHsu @csp33 @Miretpl @dano-nx @zezaeoh @rzjfr @jvoravong @chrisfregly @glennhsh @pgvishnuram @vighneshtule @uplsh580 @mrrsm @AutomationDev85 @subhash-0000 @dilshadshaik3031 @gopidesupavan @jstaf @fsellecchia @danielhoherd @CalvinKirs @Aakcht @prdai @cuerty @albundy83 @vatsrahul1001 @Spasnof @amoghrajesh @jedcunningham @potiuk @atalakey4work @shubham36deshpande @avikbesu @RobinM-code @ronaldorcampos @zyst1988 @rbm897 @eladkal @chrisfregly-angi @thejoeejoee @markhc @johnslavik
   
   ### Committer
   
   - [x] I acknowledge that I am a maintainer/committer of the Apache Airflow project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Status of testing of Apache Airflow Helm Chart 1.19.0rc2 [airflow]

Posted by "SamWheating (via GitHub)" <gi...@apache.org>.
SamWheating commented on issue #61268:
URL: https://github.com/apache/airflow/issues/61268#issuecomment-3837990819

   Can confirm that #53983 appears to work as expected in the rc. Rendered the chart locally and confirmed that the `spec.schedulerName` was correctly set in the pod template and the celery worker statefulset:
   ```bash 
   > helm template https://dist.apache.org/repos/dist/dev/airflow/helm-chart/1.19.0rc2/airflow-1.19.0.tgz --set workers.schedulerName=mycoolscheduler --set executor=CeleryKubernetesExecutor
   ...
     pod_template_file.yaml: |-
       ---
       apiVersion: v1
       kind: Pod
       metadata:
         name: placeholder-name
         labels:
           tier: airflow
           component: worker
           release: release-name
         annotations:
           cluster-autoscaler.kubernetes.io/safe-to-evict: "false"
       spec:
         ...
         schedulerName: mycoolscheduler
   ...
   # Source: airflow/templates/workers/worker-deployment.yaml
   apiVersion: apps/v1
   kind: StatefulSet
   ...
       spec:
         schedulerName: mycoolscheduler
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Status of testing of Apache Airflow Helm Chart 1.19.0rc2 [airflow]

Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on issue #61268:
URL: https://github.com/apache/airflow/issues/61268#issuecomment-3837525166

   > Here are the patches I had to apply to the RC2 chart template source, before it would render with my custom values overrides:
   > 
   > (...)
   
   Thanks @tpanza for the detailled report. Can you directly open a PR with the changes? Then we can include this in the next RC.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Status of testing of Apache Airflow Helm Chart 1.19.0rc2 [airflow]

Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on issue #61268:
URL: https://github.com/apache/airflow/issues/61268#issuecomment-3892409698

   Gotcha, yep it's in there! We always cut from main. Technically, we can create a release branch if we had to skip something that was merged to main and we couldn't take it, but we've never had to so far.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Status of testing of Apache Airflow Helm Chart 1.19.0rc2 [airflow]

Posted by "albundy83 (via GitHub)" <gi...@apache.org>.
albundy83 commented on issue #61268:
URL: https://github.com/apache/airflow/issues/61268#issuecomment-3833431967

   Hello,
   everything is good to me: https://github.com/apache/airflow/issues/53375


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Status of testing of Apache Airflow Helm Chart 1.19.0rc1 [airflow]

Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on issue #61268:
URL: https://github.com/apache/airflow/issues/61268#issuecomment-3830672945

   > All mine looks good:
   
   Wow, @Miretpl that list is impressive!
   
   I checked mine and also looking good,


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Status of testing of Apache Airflow Helm Chart 1.19.0rc2 [airflow]

Posted by "amordoch (via GitHub)" <gi...@apache.org>.
amordoch commented on issue #61268:
URL: https://github.com/apache/airflow/issues/61268#issuecomment-3832465816

   Same here for #58790 and #55106.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Status of testing of Apache Airflow Helm Chart 1.19.0rc2 [airflow]

Posted by "Miretpl (via GitHub)" <gi...@apache.org>.
Miretpl commented on issue #61268:
URL: https://github.com/apache/airflow/issues/61268#issuecomment-3873974741

   Just for visibility, would it be possible to add to the 1.19.0 release the #61565 PR? It is a doc update, which I've missed in #60238 PR (already present in the release)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Status of testing of Apache Airflow Helm Chart 1.19.0rc3 [airflow]

Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham closed issue #61268: Status of testing of Apache Airflow Helm Chart 1.19.0rc3
URL: https://github.com/apache/airflow/issues/61268


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Status of testing of Apache Airflow Helm Chart 1.19.0rc2 [airflow]

Posted by "tpanza (via GitHub)" <gi...@apache.org>.
tpanza commented on issue #61268:
URL: https://github.com/apache/airflow/issues/61268#issuecomment-3837676250

   > > Here are the patches I had to apply to the RC2 chart template source, before it would render with my custom values overrides:
   > > (...)
   > 
   > Thanks [@tpanza](https://github.com/tpanza) for the detailled report. Can you directly open a PR with the changes? Then we can include this in the next RC.
   
   @jscheffl https://github.com/apache/airflow/pull/61371


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Status of testing of Apache Airflow Helm Chart 1.19.0rc2 [airflow]

Posted by "goncalo-m-c (via GitHub)" <gi...@apache.org>.
goncalo-m-c commented on issue #61268:
URL: https://github.com/apache/airflow/issues/61268#issuecomment-3860859805

   Hello. Verified [#55832](https://github.com/apache/airflow/pull/55832) and it works as expected in RC2.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Status of testing of Apache Airflow Helm Chart 1.19.0rc2 [airflow]

Posted by "avikbesu (via GitHub)" <gi...@apache.org>.
avikbesu commented on issue #61268:
URL: https://github.com/apache/airflow/issues/61268#issuecomment-3861429206

   Hello, verified https://github.com/apache/airflow/pull/52024 worked expected.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Status of testing of Apache Airflow Helm Chart 1.19.0rc2 [airflow]

Posted by "prakharcode (via GitHub)" <gi...@apache.org>.
prakharcode commented on issue #61268:
URL: https://github.com/apache/airflow/issues/61268#issuecomment-3866915474

   Hey, verified #56057 works as expected in the RC. Rendered locally and the createUserjob is running only when enabled.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Status of testing of Apache Airflow Helm Chart 1.19.0rc2 [airflow]

Posted by "Aakcht (via GitHub)" <gi...@apache.org>.
Aakcht commented on issue #61268:
URL: https://github.com/apache/airflow/issues/61268#issuecomment-3833170961

   Hi, 
   #58317 , #54698 are documentation only changes;
   #59804 and #60575 work as expected.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Status of testing of Apache Airflow Helm Chart 1.19.0rc2 [airflow]

Posted by "ihorlukianov (via GitHub)" <gi...@apache.org>.
ihorlukianov commented on issue #61268:
URL: https://github.com/apache/airflow/issues/61268#issuecomment-3841673976

   Verified https://github.com/apache/airflow/pull/54354. Works as expected in the RC.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Status of testing of Apache Airflow Helm Chart 1.19.0rc2 [airflow]

Posted by "tpanza (via GitHub)" <gi...@apache.org>.
tpanza commented on issue #61268:
URL: https://github.com/apache/airflow/issues/61268#issuecomment-3837513573

   Here are the patches I had to apply to the RC2 chart template source, before it would render with my custom values overrides:
   
   (1) `chart/templates/api-server/api-server-service.yaml`: Emit valid YAML by ensuring that the dash is on the same line as the mapping:
   
   ```diff
   @@ -42,15 +42,13 @@
      selector:
        tier: airflow
        component: api-server
        release: {{ .Release.Name }}
      ports:
   -  {{ range .Values.apiServer.service.ports }}
   -    -
   -      {{- range $key, $val := . }}
   -      {{ $key }}: {{ tpl (toString $val) $ }}
   -      {{- end }}
   +  {{- range .Values.apiServer.service.ports }}
   +    - name: {{ .name }}
   +      port: {{ tpl (toString .port) $ | int }}
      {{- end }}
      {{- if .Values.apiServer.service.loadBalancerIP }}
      loadBalancerIP: {{ .Values.apiServer.service.loadBalancerIP }}
      {{- end }}
      {{- if .Values.apiServer.service.loadBalancerSourceRanges }}
   ```
   
   (2) `chart/templates/configmaps/configmap.yaml`: avoid Unquoted config values:
   
   ```diff
   @@ -52,11 +52,11 @@
      # These are system-specified config overrides.
      airflow.cfg: |-
        {{- range $section, $settings := $config }}
        [{{ $section }}]
        {{- range $key, $val := $settings }}
   -    {{ $key }} = {{ tpl ($val | toString) $Global }}
   +    {{ $key }} = {{ tpl ($val | toString) $Global | squote }}
        {{- end }}
        {{ end }}
   
      {{- if .Values.airflowLocalSettings }}
      airflow_local_settings.py: |-
   ```
   
   (3) `chart/templates/_helpers.yaml`: insert list elements at right level; use proper boolean casing: 
   
   ```diff
   @@ -343,11 +343,13 @@
        readOnly: true
        subPath: known_hosts
      {{- end }}
      {{- end }}
      {{- if .Values.dags.gitSync.extraVolumeMounts }}
   -    {{- tpl (toYaml .Values.dags.gitSync.extraVolumeMounts) . | nindent 2 }}
   +  {{- range .Values.dags.gitSync.extraVolumeMounts }}
   +  - {{ tpl (toYaml .) $ | nindent 4 | trim }}
   +  {{- end }}
      {{- end }}
      {{- if and .Values.dags.gitSync.containerLifecycleHooks (not .is_init) }}
      lifecycle: {{- tpl (toYaml .Values.dags.gitSync.containerLifecycleHooks) . | nindent 4 }}
      {{- end }}
    {{- end }}
   @@ -598,11 +600,11 @@
      mountPath: {{ printf "%s/dags" .Values.airflowHome }}
      {{- end }}
      {{- if .Values.dags.persistence.subPath }}
      subPath: {{ .Values.dags.persistence.subPath }}
      {{- end }}
   -  readOnly: {{ .Values.dags.gitSync.enabled | ternary "True" "False" }}
   +  readOnly: {{ .Values.dags.gitSync.enabled | ternary "true" "false" }}
    {{- end }}
   
    {{- define "airflow_config_path" -}}
      {{- printf "%s/airflow.cfg" .Values.airflowHome | quote }}
    {{- end }}
   @@ -617,22 +619,22 @@
   
    {{- define "airflow_webserver_config_mount" -}}
    - name: webserver-config
      mountPath: {{ template "airflow_webserver_config_path" . }}
      subPath: webserver_config.py
   -  readOnly: True
   +  readOnly: true
    {{- end }}
   
    {{- define "airflow_api_server_config_configmap_name" -}}
      {{- default (printf "%s-api-server-config" (include "airflow.fullname" .)) .Values.apiServer.apiServerConfigConfigMapName }}
    {{- end }}
   
    {{- define "airflow_api_server_config_mount" -}}
    - name: api-server-config
      mountPath: {{ template "airflow_webserver_config_path" . }}
      subPath: webserver_config.py
   -  readOnly: True
   +  readOnly: true
    {{- end }}
   
    {{- define "airflow_local_setting_path" -}}
      {{- printf "%s/config/airflow_local_settings.py" .Values.airflowHome | quote }}
    {{- end }}
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Status of testing of Apache Airflow Helm Chart 1.19.0rc2 [airflow]

Posted by "ronaldorcampos (via GitHub)" <gi...@apache.org>.
ronaldorcampos commented on issue #61268:
URL: https://github.com/apache/airflow/issues/61268#issuecomment-3833474683

   Hi, everything looks good on my end:
   - https://github.com/apache/airflow/pull/58626 is internal only.
   - https://github.com/apache/airflow/pull/58695, https://github.com/apache/airflow/pull/58635, https://github.com/apache/airflow/pull/58155, https://github.com/apache/airflow/pull/57985, all look good.
   
   Can also attest for https://github.com/apache/airflow/pull/58547 superb change šŸš€ 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Status of testing of Apache Airflow Helm Chart 1.19.0rc2 [airflow]

Posted by "aeroyorch (via GitHub)" <gi...@apache.org>.
aeroyorch commented on issue #61268:
URL: https://github.com/apache/airflow/issues/61268#issuecomment-3889248042

   Hi! Verified locally #58094 #58663 #58707


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Status of testing of Apache Airflow Helm Chart 1.19.0rc2 [airflow]

Posted by "Miretpl (via GitHub)" <gi...@apache.org>.
Miretpl commented on issue #61268:
URL: https://github.com/apache/airflow/issues/61268#issuecomment-3892261362

   I meant more the including the release itself, not in the release notes (I'm not sure if the rc3 is published from main after rc2, or the procedure is different). I agree that mentioning it in the release notes is not really important "news" to the user


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Status of testing of Apache Airflow Helm Chart 1.19.0rc3 [airflow]

Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on issue #61268:
URL: https://github.com/apache/airflow/issues/61268#issuecomment-3916786443

   Release is out. Thanks everyone for testing!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Status of testing of Apache Airflow Helm Chart 1.19.0rc1 [airflow]

Posted by "chrisfregly (via GitHub)" <gi...@apache.org>.
chrisfregly commented on issue #61268:
URL: https://github.com/apache/airflow/issues/61268#issuecomment-3825163434

   Yes, issue [#54673](https://github.com/apache/airflow/issues/54673) is addressed in the latest Helm Chart RC [1.19.0rc1](https://dist.apache.org/repos/dist/dev/airflow/helm-chart/1.19.0rc1).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Status of testing of Apache Airflow Helm Chart 1.19.0rc2 [airflow]

Posted by "mrrsm (via GitHub)" <gi...@apache.org>.
mrrsm commented on issue #61268:
URL: https://github.com/apache/airflow/issues/61268#issuecomment-3836056044

   Hello,
   
   https://github.com/apache/airflow/pull/59068 is working as expected


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Status of testing of Apache Airflow Helm Chart 1.19.0rc2 [airflow]

Posted by "dano-nx (via GitHub)" <gi...@apache.org>.
dano-nx commented on issue #61268:
URL: https://github.com/apache/airflow/issues/61268#issuecomment-3860153744

   Verified #51956. Works as expected in RC2. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Status of testing of Apache Airflow Helm Chart 1.19.0rc2 [airflow]

Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on issue #61268:
URL: https://github.com/apache/airflow/issues/61268#issuecomment-3891849081

   > Would it be possible to include the [#61565](https://github.com/apache/airflow/pull/61565) PR in the 1.19.0 release? It is a doc update, which I've missed in [#60238](https://github.com/apache/airflow/pull/60238) PR (already present in the release)
   
   I'd intentionally left that off when I did rc3 release notes. I think the entry for the feature is enough - a follow up docs fixup isn't that noteworthy to a user.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Status of testing of Apache Airflow Helm Chart 1.19.0rc1 [airflow]

Posted by "Miretpl (via GitHub)" <gi...@apache.org>.
Miretpl commented on issue #61268:
URL: https://github.com/apache/airflow/issues/61268#issuecomment-3826129156

   All mine looks good:
   1. https://github.com/apache/airflow/pull/52357 / https://github.com/apache/airflow/pull/59214 - reverted by https://github.com/apache/airflow/pull/60721
   2. https://github.com/apache/airflow/pull/59122
   3. https://github.com/apache/airflow/pull/59213
   4. https://github.com/apache/airflow/pull/59730
   5. https://github.com/apache/airflow/pull/60056
   6. https://github.com/apache/airflow/pull/60067
   7. https://github.com/apache/airflow/pull/60163
   8. https://github.com/apache/airflow/pull/60186
   9. https://github.com/apache/airflow/pull/60238
   10. https://github.com/apache/airflow/pull/60351
   11. https://github.com/apache/airflow/pull/60354
   12. https://github.com/apache/airflow/pull/60359
   13. https://github.com/apache/airflow/pull/60396
   14. https://github.com/apache/airflow/pull/60751
   15. https://github.com/apache/airflow/pull/61049
   16. https://github.com/apache/airflow/pull/60147
   17. https://github.com/apache/airflow/pull/60239
   18. https://github.com/apache/airflow/pull/60420
   19. https://github.com/apache/airflow/pull/61102


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org