You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "milenkovicm (via GitHub)" <gi...@apache.org> on 2023/11/01 09:33:04 UTC
Re: [PR] Break GroupedHashAggregateStream spill batch into smaller chunks [arrow-datafusion]
milenkovicm commented on code in PR #8004:
URL: https://github.com/apache/arrow-datafusion/pull/8004#discussion_r1378575129
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -2155,7 +2155,7 @@ mod tests {
spill: bool,
) -> Result<()> {
let task_ctx = if spill {
- new_spill_ctx(2, 2812)
+ new_spill_ctx(2, 2886)
Review Comment:
It is, with original value it will panic with `ResourcesExhausted` in the merge phase, so I have increase it. Did not do in depth analysis of the problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org