You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by atdixon <gi...@git.apache.org> on 2015/03/31 01:17:59 UTC

[GitHub] kafka pull request: curator + exhibitor integration

GitHub user atdixon opened a pull request:

    https://github.com/apache/kafka/pull/53

    curator + exhibitor integration

    My motivation for introducing curator to kafka was to get optional exhibitor support, however I noticed this  is also a solution to ticket KAFKA-873 (https://issues.apache.org/jira/browse/KAFKA-873).
    
    Structurally I believe the code is sound, however some tests are blocking which I believe is duet o races related to in-memory Zookeeper but not entirely sure. Am looking into it and testing outside of in-memory ZK, as well. But would love comments/discussion on this PR. I imagine exhibitor support is something that many are interested in, especially those of us in AWS & cloud environments.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/atdixon/kafka exhibitor-support

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/53.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #53
    
----
commit 3526d5664fa87b2d3f0e6e35bd5b060639df4ead
Author: Aaron Dixon <at...@gmail.com>
Date:   2015-03-30T23:15:16Z

    curator + exhibitor integration

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---