You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/09/08 03:26:34 UTC

[GitHub] [netbeans] BradWalker opened a new pull request, #4602: Cleanup warnings related to Set raw type

BradWalker opened a new pull request, #4602:
URL: https://github.com/apache/netbeans/pull/4602

   Warnings that look like this:
   
      [repeat] /home/bwalker/src/netbeans/enterprise/web.client.rest/src/org/netbeans/modules/web/client/rest/wizard/JSClientIterator.java:237: warning: [rawtypes] found raw type: Set
      [repeat]     public Set instantiate() throws IOException {
      [repeat]            ^
      [repeat]   missing type arguments for generic class Set<E>
      [repeat]   where E is a type-variable:
      [repeat]     E extends Object declared in interface Set
   
   
   
   
   
   ---
   **^Add meaningful description above**
   
   By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
   
    - are all your own work, and you have the right to contribute them.
    - are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
   
   Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
   
   If you're a first time contributor, see the Contributing guidelines for more information.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #4602: Cleanup warnings related to Set raw type

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on code in PR #4602:
URL: https://github.com/apache/netbeans/pull/4602#discussion_r986038559


##########
cpplite/cpplite.project/src/org/netbeans/modules/cpplite/project/ui/wizard/CPPLiteProjectWizardIterator.java:
##########
@@ -72,7 +72,7 @@ public class CPPLiteProjectWizardIterator implements WizardDescriptor.Instantiat
     private int idx;
 
     @Override
-    public Set instantiate() throws IOException {
+    public Set<FileObject> instantiate() throws IOException {

Review Comment:
   see comment for apisupport.ant



##########
cpplite/cpplite.debugger/src/org/netbeans/modules/cpplite/debugger/CPPLiteActionsProvider.java:
##########
@@ -69,7 +69,7 @@ public CPPLiteActionsProvider(ContextProvider contextProvider) {
     }
 
     @Override
-    public Set getActions () {
+    public Set<Object> getActions () {

Review Comment:
   I strongly suggest not to do this. This overrides `getActions`  from `org.netbeans.spi.debugger.ActionsProvider`, which is not generified. Once it is, this might break. I doubt that `Object` is a valid generic for a method that should return Actions.



##########
apisupport/apisupport.ant/src/org/netbeans/modules/apisupport/project/ui/wizard/NewNbModuleWizardIterator.java:
##########
@@ -161,7 +161,7 @@ public FileObject getCreateProjectFolder() {
         return createdProjectFolder;
     }
     
-    public Set instantiate() throws IOException {
+    public Set<FileObject> instantiate() throws IOException {

Review Comment:
   This is an override from an ungenerified superclass. This might break when generics are added to the interface.



##########
enterprise/cloud.amazon/src/org/netbeans/modules/cloud/amazon/serverplugin/AmazonJ2eePlatformImpl2.java:
##########
@@ -144,7 +144,7 @@ public boolean isToolSupported(String toolName) {
     }
 
     @Override
-    public Set getSupportedJavaPlatformVersions() {
+    public Set<String> getSupportedJavaPlatformVersions() {

Review Comment:
   The method signature of the superclass hints this is correct, yet it is not generic by itself.



##########
cpplite/cpplite.debugger/src/org/netbeans/modules/cpplite/debugger/breakpoints/CPPLiteBreakpointActionProvider.java:
##########
@@ -101,7 +101,7 @@ public void doAction (Object action) {
      * @return set of actions supported by this ActionsProvider
      */
     @Override
-    public Set getActions () {
+    public Set<Object> getActions () {

Review Comment:
   Same comment as for `CPPLiteActionsProvider` applies



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] BradWalker commented on pull request #4602: Cleanup warnings related to Set raw type

Posted by GitBox <gi...@apache.org>.
BradWalker commented on PR #4602:
URL: https://github.com/apache/netbeans/pull/4602#issuecomment-1276559503

   The proper fix for this is going to be difficult.
   
   So, closing this as will not fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] BradWalker closed pull request #4602: Cleanup warnings related to Set raw type

Posted by GitBox <gi...@apache.org>.
BradWalker closed pull request #4602: Cleanup warnings related to Set raw type
URL: https://github.com/apache/netbeans/pull/4602


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists