[GitHub] [incubator-tvm] abergeron opened a new pull request #4783: Make sure to visit the arguments of inlined functions

[GitBox <gi...@apache.org>]

abergeron opened a new pull request #4783: Make sure to visit the arguments of inlined functions
URL: https://github.com/apache/incubator-tvm/pull/4783
 
 
   This is a potential fix for #4758 
   
   I found out what causes the issue.  The module I test with has two CallNode expressions that reference the match clause: `%5 = @fn(%4);` and  `add(%2, %5)`.
   
   One of these uses the GlobalVarNode path at line https://github.com/apache/incubator-tvm/blob/master/src/relay/backend/vm/inline_primitives.cc#L94 which doesn't visit its arguments but just uses them directly from the original expression.
   
   The other uses the default path at the end of the CallNode visitor which does visit its arguments, clones the match and uses it for the new call node it returns.
   
   My fix is to always visit the arguments so that all path use the same "version" of the expressions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] jroesch merged pull request #4783: Make sure to visit the arguments of inlined functions

[GitBox <gi...@apache.org>]

jroesch merged pull request #4783: Make sure to visit the arguments of inlined functions
URL: https://github.com/apache/incubator-tvm/pull/4783
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services