[GitHub] [samza] shanthoosh commented on a change in pull request #955: SAMZA-2131: [Scala cleanup] Convert FileSystemCheckpointManagerConfig.scala and SystemConfig.scala to Java

[GitBox <gi...@apache.org>]

shanthoosh commented on a change in pull request #955: SAMZA-2131: [Scala cleanup] Convert FileSystemCheckpointManagerConfig.scala and SystemConfig.scala to Java
URL: https://github.com/apache/samza/pull/955#discussion_r268481222
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/config/SystemConfig.java
 ##########
 @@ -147,4 +153,31 @@ public String getSystemOffsetDefault(String systemName) {
 
     return systemOffsetDefault;
   }
+
+  public Optional<String> getSystemKeySerde(String systemName) {
+    return getSystemDefaultStreamProperty(systemName, StreamConfig.KEY_SERDE());
+  }
+
+  public Optional<String> getSystemMsgSerde(String systemName) {
+    return getSystemDefaultStreamProperty(systemName, StreamConfig.MSG_SERDE());
+  }
+
+  public boolean deleteCommittedMessages(String systemName) {
+    return getBoolean(String.format(DELETE_COMMITTED_MESSAGES, systemName), false);
+  }
+
+  private Optional<String> getSystemDefaultStreamProperty(String systemName, String propertyName) {
 
 Review comment:
   Minor: Would be better to add java docs for this the method. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services