You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/19 14:48:00 UTC
[jira] [Commented] (FLINK-6786) Remove duplicate QueryScopeInfoTest
[ https://issues.apache.org/jira/browse/FLINK-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054128#comment-16054128 ]
ASF GitHub Bot commented on FLINK-6786:
---------------------------------------
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4034#discussion_r122725538
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/metrics/dump/QueryScopeInfoTest.java ---
@@ -20,58 +20,140 @@
import org.junit.Test;
-import static org.apache.flink.runtime.metrics.dump.QueryScopeInfo.INFO_CATEGORY_JM;
--- End diff --
I would leave that static imports for readability
> Remove duplicate QueryScopeInfoTest
> -----------------------------------
>
> Key: FLINK-6786
> URL: https://issues.apache.org/jira/browse/FLINK-6786
> Project: Flink
> Issue Type: Improvement
> Components: Metrics, Tests
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>
> The {{QueryScopeInfoTest}} exists twice in {{runtime/metrics}}, under {{groups/}} and {{dump/}}.
> These should be merged together.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)