You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/12/07 07:05:54 UTC
Re: Review Request 63390: Unit tests for storage local resource
provider.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63390/
-----------------------------------------------------------
(Updated Dec. 7, 2017, 7:05 a.m.)
Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht.
Changes
-------
Addressed Jie's comments and added another test.
Summary (updated)
-----------------
Unit tests for storage local resource provider.
Repository: mesos
Description (updated)
-------
This patche adds two unit tests. The first one will register a framework
to issue a `CREATE_VOLUME` then a `DESTROY_VOLUME` call to destroy
an unpublised volume. The second one will register a framework to issue
`CREATE_VOLUME`, `CREATE`, `LAUNCH`, `DESTROY_VOLUME` in sequence to
create a volume and launch a task to use a persistent volume on the CSI
volume, then destroy this published volume.
Diffs (updated)
-----
src/Makefile.am be105f485124579f70888bda69d3c37fd5a18770
src/examples/test_csi_plugin.cpp 8ab936ba6ba6942452b8cb29bb9a8a4f85c02e53
src/tests/mesos.hpp 3a9b1fbd4301c6cccbc770329ff71ed8ff7e86a2
src/tests/storage_local_resource_provider_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/63390/diff/5/
Changes: https://reviews.apache.org/r/63390/diff/4-5/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 63390: Unit tests for storage local resource
provider.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63390/
-----------------------------------------------------------
(Updated Dec. 7, 2017, 8:48 p.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, Joseph Wu, and Jan Schlicht.
Changes
-------
`DESTROY` before `DESTROY_VOLUME` and bypass `DESTROY` validation for provider resources.
Repository: mesos
Description
-------
This patche adds two unit tests. The first one will register a framework
to issue a `CREATE_VOLUME` then a `DESTROY_VOLUME` call to destroy
an unpublised volume. The second one will register a framework to issue
`CREATE_VOLUME`, `CREATE`, `LAUNCH`, `DESTROY_VOLUME` in sequence to
create a volume and launch a task to use a persistent volume on the CSI
volume, then destroy this published volume.
Diffs (updated)
-----
src/Makefile.am be105f485124579f70888bda69d3c37fd5a18770
src/examples/test_csi_plugin.cpp 8ab936ba6ba6942452b8cb29bb9a8a4f85c02e53
src/master/validation.cpp bf7ae65cad79c14f11e1858a16bd6d1b2f7745e7
src/tests/mesos.hpp 3a9b1fbd4301c6cccbc770329ff71ed8ff7e86a2
src/tests/storage_local_resource_provider_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/63390/diff/8/
Changes: https://reviews.apache.org/r/63390/diff/7-8/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao