[GitHub] [incubator-brpc] zyearn commented on a diff in pull request #1814: fix ssl state exception coredump

[GitBox <gi...@apache.org>]

zyearn commented on code in PR #1814:
URL: https://github.com/apache/incubator-brpc/pull/1814#discussion_r912206994


##########
src/brpc/socket_map.cpp:
##########
@@ -301,6 +301,7 @@ void SocketMap::RemoveInternal(const SocketMapKey& key,
                 _this_map_bvar = new bvar::PassiveStatus<std::string>(
                     butil::StringPiece(namebuf, len), PrintSocketMap, this);
             }
+            s->DisableHealthCheck(); // disable health check

Review Comment:
   怎么理解在Socket没有进行health check的时候调用DisableHealthCheck



##########
src/brpc/socket.h:
##########
@@ -747,6 +750,11 @@ friend void DereferenceSocket(Socket*);
     // Non-zero when health-checking is on.
     int _health_check_interval_s;
 
+    // Default: true,
+    // false when client SocketMap has removed socket.
+    // It can be synchronized via _versioned_ref atomic variable
+    bool _enalbe_health_check;

Review Comment:
   在上面的_health_check_interval_s注释里说Non-zero when health-checking is on，然后又出现一个_enalbe_health_check，这个flag的意义有点和_health_check_interval_s混淆



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org